fix(exports): merge multi-config outputs (#625)

Co-authored-by: Kevin Deng <sxzz@sxzz.moe>

Author: pyyupsk

src/features/exports.ts

@@ -36,6 +36,8 @@ export interface ExportsOptions {
   ) => Awaitable<Record<string, any>>
 }
 
+export const exportsState: Map<string, Set<TsdownChunks>> = new Map()
+
 export async function writeExports(
   options: ResolvedConfig,
   chunks: TsdownChunks,
@@ -47,10 +49,19 @@ export async function writeExports(
     throw new Error('`package.json` not found, cannot write exports')
   }
 
+  const stateKey = `${pkg.packageJsonPath as string}::${outDir}`
+  let chunkSets = exportsState.get(stateKey)
+  if (!chunkSets) {
+    chunkSets = new Set()
+    exportsState.set(stateKey, chunkSets)
+  }
+  chunkSets.add(chunks)
+  const mergedChunks = mergeChunks(chunkSets)
+
   const { publishExports, ...generated } = await generateExports(
     pkg,
     outDir,
-    chunks,
+    mergedChunks,
     options.exports,
   )
 
@@ -272,3 +283,18 @@ export function hasExportsTypes(pkg?: PackageJson): boolean {
 
   return false
 }
+
+function mergeChunks(chunkSets: Set<TsdownChunks>): TsdownChunks {
+  const merged: TsdownChunks = {}
+  for (const chunkSet of chunkSets) {
+    for (const [format, chunks] of Object.entries(chunkSet) as [
+      NormalizedFormat,
+      (OutputChunk | OutputAsset)[],
+    ][]) {
+      if (!chunks.length) continue
+      const target = (merged[format] ||= [])
+      target.push(...chunks)
+    }
+  }
+  return merged
+}

src/index.ts

@@ -19,7 +19,11 @@ import { attw } from './features/attw.ts'
 import { warnLegacyCJS } from './features/cjs.ts'
 import { cleanOutDir, cleanupChunks } from './features/clean.ts'
 import { copy } from './features/copy.ts'
-import { writeExports, type TsdownChunks } from './features/exports.ts'
+import {
+  exportsState,
+  writeExports,
+  type TsdownChunks,
+} from './features/exports.ts'
 import { createHooks, executeOnSuccess } from './features/hooks.ts'
 import { publint } from './features/publint.ts'
 import {
@@ -45,6 +49,8 @@ export interface TsdownBundle extends AsyncDisposable {
 export async function build(
   userOptions: InlineConfig = {},
 ): Promise<TsdownBundle[]> {
+  exportsState.clear()
+
   globalLogger.level =
     userOptions.logLevel || (userOptions.silent ? 'error' : 'info')
   const { configs, files: configFiles } = await resolveConfig(userOptions)

tests/__snapshots__/issues/566.snap.md

@@ -0,0 +1,10 @@
+## index.node.cjs
+
+```cjs
+
+//#region src/index.node.ts
+const platform = "node";
+
+//#endregion
+exports.platform = platform;
+```

tests/issues.test.ts

@@ -1,3 +1,5 @@
+import { readFile } from 'node:fs/promises'
+import path from 'node:path'
 import { exec } from 'tinyexec'
 import { describe, expect, test } from 'vitest'
 import { testBuild } from './utils.ts'
@@ -113,4 +115,58 @@ describe('issues', () => {
       },
     })
   })
+
+  test('#566', async (context) => {
+    const { testDir } = await testBuild({
+      context,
+      files: {
+        'src/index.browser.ts': `export const platform = 'browser'`,
+        'src/index.node.ts': `export const platform = 'node'`,
+        'tsdown.config.ts': `
+          export default [
+            {
+              entry: './src/index.browser.ts',
+              format: 'es',
+              exports: true,
+              hash: false,
+              platform: 'browser',
+            },
+            {
+              entry: './src/index.node.ts',
+              format: 'cjs',
+              exports: true,
+              hash: false,
+              platform: 'node',
+            },
+          ]
+        `,
+        'package.json': JSON.stringify({
+          name: 'issue-566',
+          version: '1.0.0',
+        }),
+        'tsconfig.json': JSON.stringify({
+          compilerOptions: { moduleResolution: 'bundler' },
+        }),
+      },
+      options: {
+        entry: undefined,
+        config: 'tsdown.config.ts',
+        dts: false,
+      },
+      expectPattern: '**/*.{js,cjs,d.mts}',
+    })
+
+    const pkg = JSON.parse(
+      await readFile(path.join(testDir, 'package.json'), 'utf8'),
+    )
+    expect(pkg.main).toBe('./dist/index.node.cjs')
+    expect(pkg.module).toBe('./dist/index.browser.mjs')
+    expect(pkg.exports).toEqual({
+      '.': {
+        import: './dist/index.browser.mjs',
+        require: './dist/index.node.cjs',
+      },
+      './package.json': './package.json',
+    })
+  })
 })

tests/utils.ts

@@ -5,7 +5,7 @@ import { fileURLToPath } from 'node:url'
 import { expectFilesSnapshot } from '@sxzz/test-utils'
 import { glob } from 'tinyglobby'
 import { mergeUserOptions } from '../src/config/options.ts'
-import { build, type UserConfig } from '../src/index.ts'
+import { build } from '../src/index.ts'
 import type { InlineConfig } from '../src/config/index.ts'
 import type { RollupLog } from 'rolldown'
 import type { RunnerTask, TestContext } from 'vitest'
@@ -92,7 +92,7 @@ export interface TestBuildOptions {
   /**
    * The options for the build.
    */
-  options?: UserConfig | ((cwd: string) => UserConfig)
+  options?: InlineConfig | ((cwd: string) => InlineConfig)
 
   /**
    * The working directory of the test. It's a relative path to the test directory.
@@ -162,6 +162,13 @@ export async function testBuild({
       return options
     },
   }
+  if (
+    userOptions &&
+    userOptions.entry == null &&
+    Object.hasOwn(userOptions, 'entry')
+  ) {
+    delete resolvedOptions.entry
+  }
   await beforeBuild?.()
   await build(resolvedOptions)
   restoreCwd()