Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill-node #94

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add polyfill-node #94

merged 1 commit into from
Nov 15, 2021

Conversation

curran
Copy link
Contributor

@curran curran commented Jul 24, 2021

Awesome Contribution Checklist:

  • I have read, and re-read the Contributing Guidelines
  • I have searched to ensure the suggested item doesn't exist on this list
  • This PR contains only one item

Please Provide a Link A Repository for Your Addition

https://github.com/snowpackjs/rollup-plugin-polyfill-node

Please Describe Your Addition

As a follow-up to #92, it turns out that this package is the most up to date choice for including Node builtins into Rollup bundles.

Also related: rollup/rollup#4190

@@ -238,8 +238,9 @@ Plugins which affect the Rollup workflow.
- [html-entry](https://github.com/leogr/rollup-plugin-html-entry) – Allows use HTML Script Tags as entry points.
- [incremental](https://github.com/mprt-org/rollup-plugin-incremental) - Recompile only changed modules in watch mode.
- [jscc](https://github.com/aMarCruz/rollup-plugin-jscc) – Conditional compilation and declaration of ES6 imports.
- [make](https://github.com/btmorex/rollup-plugin-make) - Build dependency files suitable for make.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I noticed while doing this that the alphabetical ordering was off, and there was no period at the end of the sentence for make. So I fixed both.

@shellscape
Copy link
Contributor

thanks!

@shellscape shellscape merged commit 1855d21 into rollup:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants