Skip to content

Fix ROOT files selection with RFileDialog class #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix ROOT files selection with RFileDialog class #12093

merged 2 commits into from
Jan 24, 2023

Conversation

linev
Copy link
Member

@linev linev commented Jan 23, 2023

@linev linev requested review from bellenot and couet as code owners January 23, 2023 14:55
@linev linev self-assigned this Jan 23, 2023
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

This was referenced Jan 23, 2023
Merged
Merged
@phsft-bot
Copy link

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-01-23T15:04:15.325Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

bellenot
bellenot approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@linev linev merged commit 170b262 into root-project:master Jan 24, 2023
@linev linev deleted the fix_rdialog branch January 24, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot bellenot approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

Assignees

@linev linev

Labels

affects:master in:WebGui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linev @phsft-bot @bellenot