Skip to content

Fix ROOT files selection with RFileDialog class #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix ROOT files selection with RFileDialog class #12093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a92a90d
Provide ROOT file name in RFileDialog
linev Jan 23, 2023
4df5060
Add ROOT files selection in RFileDialog tutorial
linev Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gui/browsable/src/TDirectoryElement.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,14 @@ class TDirectoryElement : public TObjectElement {
return ""s;
}

std::string GetContent(const std::string &kind) override
{
if (GetContentKind(kind) == kFileName)
return fFileName;

return ""s;
}

};

// ===============================================================================================================
Expand Down
4 changes: 2 additions & 2 deletions tutorials/v7/filedialog.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ void filedialog(int kind = 0)

auto dialog = std::make_shared<RFileDialog>(RFileDialog::kOpenFile, "OpenFile dialog in async mode");

dialog->SetNameFilters({ "C++ files (*.cxx *.cpp *.c *.C)", "Image files (*.png *.jpg *.jpeg)", "Text files (*.txt)", "Any files (*)" });
dialog->SetNameFilters({ "C++ files (*.cxx *.cpp *.c *.C)", "ROOT files (*.root)", "Image files (*.png *.jpg *.jpeg)", "Text files (*.txt)", "Any files (*)" });

dialog->SetSelectedFilter("C++ files");
dialog->SetSelectedFilter("ROOT files");

// use dialog capture to keep reference until file name is selected
dialog->SetCallback([dialog](const std::string &res) mutable {
Expand Down