chore(deps): ⬆️ bump squizlabs/php_codesniffer to v3.9.1

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
squizlabs/php_codesniffer	3.8.1 -> 3.9.1

---

Release Notes

PHPCSStandards/PHP_CodeSniffer (squizlabs/php_codesniffer)

v3.9.1

Compare Source

Added

• Documentation for the following sniffs:
  • Generic.PHP.RequireStrictTypes
  • Squiz.WhiteSpace.MemberVarSpacing
  • Squiz.WhiteSpace.ScopeClosingBrace
  • Squiz.WhiteSpace.SuperfluousWhitespace
  • Thanks to [Jay McPartland][@​jonmcp] and [Rodrigo Primo][@​rodrigoprimo] for the patches.

Changed

• The following sniffs have received performance related improvements:
  • Generic.CodeAnalysis.UselessOverridingMethod
  • Generic.Files.ByteOrderMark
  • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patches.
• Performance improvement for the "Diff" report. Should be most notable for Windows users. #​355
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
• The test suite has received some performance improvements. Should be most notable contributors using Windows. #​351
  • External standards with sniff tests using the PHP_CodeSniffer native test framework will also benefit from these changes.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch.
• Various housekeeping, including improvements to the tests and documentation.
  • Thanks to [Jay McPartland][@​jonmcp], [João Pedro Oliveira][@​jpoliveira08], [Rodrigo Primo][@​rodrigoprimo] and [Juliette Reinders Folmer][@​jrfnl] for their contributions.

Fixed

• Fixed bug #​289 : Squiz.WhiteSpace.OperatorSpacing and PSR12.Operators.OperatorSpacing : improved fixer conflict protection by more strenuously avoiding handling operators in declare statements.
  • Thanks to [Dan Wallis][@​fredden] for the patch.
• Fixed bug #​366 : Generic.CodeAnalysis.UselessOverridingMethod : prevent false negative when the declared method name and the called method name do not use the same case.
  • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patch.
• Fixed bug #​368 : Squiz.Arrays.ArrayDeclaration fixer did not handle static closures correctly when moving array items to their own line.
  • Thanks to [Michał Bundyra][@​michalbundyra] for the patch.
• Fixed bug #​404 : Test framework : fixed PHP 8.4 deprecation notice.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch

v3.9.0

Compare Source

Added

• Tokenizer support for PHP 8.3 typed class constants. #​321
  • Additionally, the following sniffs have been updated to support typed class constants:
    • Generic.NamingConventions.UpperCaseConstantName #​332
    • Generic.PHP.LowerCaseConstant #​330
    • Generic.PHP.LowerCaseType #​331
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
• Tokenizer support for PHP 8.3 readonly anonymous classes. #​309
  • Additionally, the following sniffs have been updated to support readonly anonymous classes:
    • PSR12.Classes.ClassInstantiation #​324
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patches
• New PHP_CodeSniffer\Sniffs\DeprecatedSniff interface to allow for marking a sniff as deprecated. #​281
  • If a ruleset uses deprecated sniffs, deprecation notices will be shown to the end-user before the scan starts.
    When running in -q (quiet) mode, the deprecation notices will be hidden.
  • Deprecated sniffs will still run and using them will have no impact on the exit code for a scan.
  • In ruleset "explain"-mode (-e) an asterix * will show next to deprecated sniffs.
  • Sniff maintainers are advised to read through the PR description for full details on how to use this feature for their own (deprecated) sniffs.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• New Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence sniff. #​197
  • Forbid mixing different binary boolean operators within a single expression without making precedence clear using parentheses
  • Thanks to [Tim Düsterhus][@​TimWolla] for the contribution
• Squiz.PHP.EmbeddedPhp : the sniff will now also examine the formatting of embedded PHP statements using short open echo tags. #​27
  • Includes a new ShortOpenEchoNoSemicolon errorcode to allow for selectively ignoring missing semicolons in single line embedded PHP snippets within short open echo tags.
  • The other error codes are the same and do not distinguish between what type of open tag was used.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Documentation for the following sniffs:
  • Generic.WhiteSpace.IncrementDecrementSpacing
  • PSR12.ControlStructures.ControlStructureSpacing
  • PSR12.Files.ImportStatement
  • PSR12.Functions.ReturnTypeDeclaration
  • PSR12.Properties.ConstantVisibility
  • Thanks to [Denis Žoljom][@​dingo-d] and [Rodrigo Primo][@​rodrigoprimo] for the patches

Changed

• The Performance report can now also be used for a phpcbf run. #​308
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Sniff tests which extend the PHPCS native AbstractSniffUnitTest class will now show a (non-build-breaking) warning when test case files contain fixable errors/warnings, but there is no corresponding .fixed file available in the test suite to verify the fixes against. #​336
  • The warning is only displayed on PHPUnit 7.3.0 and higher.
  • The warning will be elevated to a test failure in PHPCS 4.0.
  • Thanks to [Dan Wallis][@​fredden] for the patch
• The following sniffs have received performance related improvements:
  • Squiz.PHP.EmbeddedPhp
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Various housekeeping, including improvements to the tests and documentation
  • Thanks to [Dan Wallis][@​fredden], [Joachim Noreiko][@​joachim-n], [Remi Collet][@​remicollet], [Rodrigo Primo][@​rodrigoprimo] and [Juliette Reinders Folmer][@​jrfnl] for their contributions

Deprecated

• Support for scanning JavaScript and CSS files. See #​2448.
  • This also means that all sniffs which are only aimed at JavaScript or CSS files are now deprecated.
  • The Javascript and CSS Tokenizers, all Javascript and CSS specific sniffs, and support for JS and CSS in select sniffs which support multiple file types, will be removed in version 4.0.0.
• The abstract PHP_CodeSniffer\Filters\ExactMatch::getBlacklist() and PHP_CodeSniffer\Filters\ExactMatch::getWhitelist() methods are deprecated and will be removed in the 4.0 release. See #​198.
  • In version 4.0, these methods will be replaced with abstract ExactMatch::getDisallowedFiles() and ExactMatch::getAllowedFiles() methods
  • To make Filters extending ExactMatch cross-version compatible with both PHP_CodeSniffer 3.9.0+ as well as 4.0+, implement the new getDisallowedFiles() and getAllowedFiles() methods.
    • When both the getDisallowedFiles() and getAllowedFiles() methods as well as the getBlacklist() and getWhitelist() are available, the new methods will take precedence over the old methods.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• The MySource standard and all sniffs in it. See #​2471.
  • The MySource standard and all sniffs in it will be removed in version 4.0.0.
• The Zend.Debug.CodeAnalyzer sniff. See #​277.
  • This sniff will be removed in version 4.0.0.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch

Fixed

• Fixed bug #​127 : Squiz.Commenting.FunctionComment : The MissingParamType error code will now be used instead of MissingParamName when a parameter name is provided, but not its type. Additionally, invalid type hint suggestions will no longer be provided in these cases.
  • Thanks to [Dan Wallis][@​fredden] for the patch
• Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : fixer will no longer leave behind trailing whitespace when moving code to another line.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : will now determine the needed indent with higher precision in multiple situations.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​196 : Squiz.PHP.EmbeddedPhp : fixer will no longer insert a stray new line when the closer of a multi-line embedded PHP block and the opener of the next multi-line embedded PHP block would be on the same line.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​235 : Generic.CodeAnalysis.ForLoopWithTestFunctionCall : prevent a potential PHP 8.3 deprecation notice during live coding
  • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patch
• Fixed bug #​288 : Generic.WhiteSpace.IncrementDecrementSpacing : error message for post-in/decrement will now correctly inform about new lines found before the operator.
  • Thanks to [Rodrigo Primo][@​rodrigoprimo] for the patch
• Fixed bug #​296 : Generic.WhiteSpace.ArbitraryParenthesesSpacing : false positive for non-arbitrary parentheses when these follow the scope closer of a switch case.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​307 : PSR2.Classes.ClassDeclaration : space between a modifier keyword and the class keyword was not checked when the space included a new line or comment.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​325 : Squiz.Operators.IncrementDecrementUsage : the sniff was underreporting when there was (no) whitespace and/or comments in unexpected places.
  • Thanks to [Juliette Reinders Folmer][@​jrfnl] for the patch
• Fixed bug #​335 : PSR12.Files.DeclareStatement : bow out in a certain parse error situation to prevent incorrect auto-fixes from being made.
  • Thanks to [Dan Wallis][@​fredden] for the patch
• Fixed bug #​340 : Squiz.Commenting.ClosingDeclarationComment : no longer adds a stray newline when adding a missing comment.
  • Thanks to [Dan Wallis][@​fredden] for the patch

Other

• A "Community cc list" has been introduced to ping maintainers of external standards and integrators for input regarding change proposals for PHP_CodeSniffer which may impact them. #​227
  • For anyone who missed the discussion about this and is interested to be on this list, please feel invited to submit a PR to add yourself.
    The list is located in the .github folder.

---

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.