Skip to content
This repository was archived by the owner on Aug 8, 2024. It is now read-only.

Conversation

@isonet
Copy link

@isonet isonet commented Oct 6, 2014

I'm not a python expert, but this fixed a bug for me, so maybe you can check it out? Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cc78cfe on isonet:master into 3d4ab33 on rory:master.

@amandasaurus
Copy link
Owner

That's interesting. Can you give me an example input which used to fail that this bug fixes?

@isonet
Copy link
Author

isonet commented Oct 15, 2014

Sorry for the delay.
I did some tests and apparently my logfile changed it's format mid-way...So your code is fine.
Great tool btw, it was very useful to me. I implemented it here: https://github.com/isonet/apache-log-to-csv

@isonet isonet closed this Oct 15, 2014
@amandasaurus
Copy link
Owner

Glad you got your problem solved. :)

BTW do you know about pip etc? You can specify dependencies for your library on another, makes it easier for people to install your tool.

@isonet
Copy link
Author

isonet commented Oct 15, 2014

:)

Yeah, I'm currently looking into it. Travis & Coveralls seem to be a good idea too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants