Skip to content

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented Oct 1, 2025

Since CMakeLists.txt contains "find_package(backward_ros REQUIRED)", without this change, compilation can fail with the following error:

CMake Error at CMakeLists.txt:25 (find_package):
  By not providing "Findbackward_ros.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "backward_ros", but CMake did not find one.

This change fixes that.

Since CMakeLists.txt contains "find_package(backward_ros REQUIRED)",
without this change, compilation can fail with the following error:

    CMake Error at CMakeLists.txt:25 (find_package):
      By not providing "Findbackward_ros.cmake" in CMAKE_MODULE_PATH this project
      has asked CMake to find a package configuration file provided by
      "backward_ros", but CMake did not find one.

This change fixes that.

Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.23%. Comparing base (e1706a3) to head (9997e37).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1941   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files         143      143           
  Lines       13795    13795           
  Branches     1197     1197           
=======================================
  Hits        11758    11758           
  Misses       1639     1639           
  Partials      398      398           
Flag Coverage Δ
unittests 85.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bmagyar bmagyar merged commit 2186969 into ros-controls:master Oct 2, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features Oct 2, 2025
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants