-
Notifications
You must be signed in to change notification settings - Fork 406
mecanum_drive_controller: Declare missing backward_ros dependency #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since CMakeLists.txt contains "find_package(backward_ros REQUIRED)", without this change, compilation can fail with the following error: CMake Error at CMakeLists.txt:25 (find_package): By not providing "Findbackward_ros.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "backward_ros", but CMake did not find one. This change fixes that. Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1941 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 143 143
Lines 13795 13795
Branches 1197 1197
=======================================
Hits 11758 11758
Misses 1639 1639
Partials 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
) (cherry picked from commit 2186969)
) (cherry picked from commit 2186969)
Since CMakeLists.txt contains "find_package(backward_ros REQUIRED)", without this change, compilation can fail with the following error:
This change fixes that.