Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[velodyne_pointcloud] add_two_pt scripts #473

Merged
merged 4 commits into from
Dec 17, 2022
Merged

[velodyne_pointcloud] add_two_pt scripts #473

merged 4 commits into from
Dec 17, 2022

Conversation

PierrickKoch
Copy link
Contributor

@JWhitleyWork
Copy link
Contributor

@PierrickKoch Instead of providing a script to do this, can you just apply it to the example calibration file?

@JWhitleyWork
Copy link
Contributor

@PierrickKoch Friendly ping.

JWhitleyWork
JWhitleyWork approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged, would you also mind forward-porting it to the ros2 branch?

@JWhitleyWork JWhitleyWork merged commit 16be797 into ros-drivers:master Dec 17, 2022
@PierrickKoch PierrickKoch mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JWhitleyWork JWhitleyWork JWhitleyWork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrickKoch @JWhitleyWork