feat: support vls128 for ros2 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clalancette @JWhitleyWork Could you review this PR? |
|
Has this been tested on real hardware? |
|
Not yet. I will test on real sensor. |
|
I have tested and it doesn't work. |
|
@Mtestor Thank you for testing. Could you create a PR to my branch? |
|
sure |
|
@wep21 your branch doesn't appear when i try to pull request. |
|
Thanks ! I have done a PR. |
Fix Rolling CI and associated linter errors.
* Add support for the velodyne Alpha Prime * Change packet rate for the VLS128 according to the times specified in the manual * Organize setup functions to avoid code duplication. Add a constant for the model ID of the VLS128. * Use the defined constants to calculate the time offset of the points for the VLS128 Co-authored-by: jugo <juan.gonzalez@unibw.de>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…iable where there are used
|
Rebased on current |
JWhitleyWork
approved these changes
May 29, 2023
JWhitleyWork
added a commit
that referenced
this pull request
May 29, 2023
* Update rolling ci (#512) Fix Rolling CI and associated linter errors. * Add support for the velodyne Alpha Prime (#370) * Add support for the velodyne Alpha Prime * Change packet rate for the VLS128 according to the times specified in the manual * Organize setup functions to avoid code duplication. Add a constant for the model ID of the VLS128. * Use the defined constants to calculate the time offset of the points for the VLS128 Co-authored-by: jugo <juan.gonzalez@unibw.de> * Add VLS128 launch and calibration file (#382) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * vls128: add line only once all four banks are processed (#413) Signed-off-by: Sebastian Scherer (CR/AAS3) <sebastian.scherer2@de.bosch.com> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix: apply uncrustify Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fixing incorrect type in velodyne_pointcloud. * Fixed non working vls128 fork * Added organized cloud compliance and remove some useless code * Corrected the azimuth offset calculation and put the declation of variable where there are used * Fix linter errors. --------- Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Sebastian Scherer (CR/AAS3) <sebastian.scherer2@de.bosch.com> Co-authored-by: Joshua Whitley <josh@electrifiedautonomy.com> Co-authored-by: Institute for Autonomous Systems Technology <tas@unibw.de> Co-authored-by: jugo <juan.gonzalez@unibw.de> Co-authored-by: Sebastian Scherer <sebastian.scherer2@de.bosch.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Mtestor <mucevval@gmail.com>
JWhitleyWork
added a commit
that referenced
this pull request
May 31, 2023
* feat: support vls128 for ros2 (#493) * Update rolling ci (#512) Fix Rolling CI and associated linter errors. * Add support for the velodyne Alpha Prime (#370) * Add support for the velodyne Alpha Prime * Change packet rate for the VLS128 according to the times specified in the manual * Organize setup functions to avoid code duplication. Add a constant for the model ID of the VLS128. * Use the defined constants to calculate the time offset of the points for the VLS128 Co-authored-by: jugo <juan.gonzalez@unibw.de> * Add VLS128 launch and calibration file (#382) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * vls128: add line only once all four banks are processed (#413) Signed-off-by: Sebastian Scherer (CR/AAS3) <sebastian.scherer2@de.bosch.com> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix: apply uncrustify Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fixing incorrect type in velodyne_pointcloud. * Fixed non working vls128 fork * Added organized cloud compliance and remove some useless code * Corrected the azimuth offset calculation and put the declation of variable where there are used * Fix linter errors. --------- Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Sebastian Scherer (CR/AAS3) <sebastian.scherer2@de.bosch.com> Co-authored-by: Joshua Whitley <josh@electrifiedautonomy.com> Co-authored-by: Institute for Autonomous Systems Technology <tas@unibw.de> Co-authored-by: jugo <juan.gonzalez@unibw.de> Co-authored-by: Sebastian Scherer <sebastian.scherer2@de.bosch.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Mtestor <mucevval@gmail.com> * Fix double include --------- Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Sebastian Scherer (CR/AAS3) <sebastian.scherer2@de.bosch.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Institute for Autonomous Systems Technology <tas@unibw.de> Co-authored-by: jugo <juan.gonzalez@unibw.de> Co-authored-by: Sebastian Scherer <sebastian.scherer2@de.bosch.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Mtestor <mucevval@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2 port for #370, #382, #413