Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The last frame was published indefinitely when playing a video file, … #97

Merged
merged 1 commit into from
Apr 13, 2021
Merged

The last frame was published indefinitely when playing a video file, … #97

merged 1 commit into from
Apr 13, 2021

Conversation

awesomebytes
Copy link
Member

…now we stop.

Fixes: #73

@awesomebytes
Copy link
Member Author

@furushchev would you like to have a look? I don't think we will be breaking any behaviour that anyone would rely on... or so I hope.

@awesomebytes awesomebytes mentioned this pull request Apr 10, 2021
Closed
furushchev
furushchev approved these changes Apr 11, 2021
View reviewed changes
Copy link
Collaborator

@furushchev furushchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, If I review strictly, by this change, the FPS of published images are not always the same as the one set in rosparam, but I don't think this change has any side effect though.

@awesomebytes awesomebytes merged commit 65949bd into master Apr 13, 2021
@awesomebytes awesomebytes deleted the dont_republish_same_image_indefinitely branch April 13, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furushchev furushchev furushchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node continues to publish last frame after end of video
2 participants
@awesomebytes @furushchev