-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added export macro to generated protobuf C++ files, and force include generated export header #113
Conversation
The CI is failing with error:
that is because GitHub Action changed its API. It is probably sufficient to bump the version of the used run-vcpkg action to the latest one (v5.0). Indeed, you can see that it started failing two days ago in the GitHub Actions history: https://github.com/ros-industrial/abb_libegm/actions . If you want I can submit a PR to fix this. |
Thanks for the quick information, I was just trying to figure out what went wrong 😅
Yes please, it would be great and much appreciated if you submit a PR. As a side note, it looks like the same issue happens for abb_librws actions. |
The Travis CI job 211.1 ( @gavanderhoorn, Edit: Nevermind, it seems to succeed now. |
… generated export header
412b4b7
to
829be44
Compare
Synced with the base branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pff .. Windows .. 🤷♂️ ;)
Thanks for the help @traversaro 👍, as well as the approval @gavanderhoorn 👍 |
As per title.
This is based on #63 (comment), for a solution to linking issues for shared libraries when using
MSVC
.