Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added export macro to generated protobuf C++ files, and force include generated export header #113

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Nov 18, 2020

As per title.

This is based on #63 (comment), for a solution to linking issues for shared libraries when using MSVC.

@traversaro
Copy link
Contributor

The CI is failing with error:

Error: Unable to process command '::set-env name=RUNVCPKG_VCPKG_TRIPLET::x64-windows' successfully.
  Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

that is because GitHub Action changed its API. It is probably sufficient to bump the version of the used run-vcpkg action to the latest one (v5.0). Indeed, you can see that it started failing two days ago in the GitHub Actions history: https://github.com/ros-industrial/abb_libegm/actions . If you want I can submit a PR to fix this.

@jontje
Copy link
Contributor Author

jontje commented Nov 18, 2020

The CI is failing with error:

Error: Unable to process command '::set-env name=RUNVCPKG_VCPKG_TRIPLET::x64-windows' successfully.
  Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

that is because GitHub Action changed its API. It is probably sufficient to bump the version of the used run-vcpkg action to the latest one (v5.0). Indeed, you can see that it started failing two days ago in the GitHub Actions history: https://github.com/ros-industrial/abb_libegm/actions .

Thanks for the quick information, I was just trying to figure out what went wrong 😅

If you want I can submit a PR to fix this.

Yes please, it would be great and much appreciated if you submit a PR.

As a side note, it looks like the same issue happens for abb_librws actions.

@jontje
Copy link
Contributor Author

jontje commented Nov 18, 2020

The Travis CI job 211.1 (ROS_DISTRO="kinetic" ROS_REPO=ros CATKIN_LINT=true) fails in the 'install_catkin_lint' function. The build target function succeeds as far as I can see.

@gavanderhoorn, do you know what the reason could be? The error is TypeError: unsupported operand type(s) for -=: 'Retry' and 'int'.

Edit: Nevermind, it seems to succeed now.

@jontje
Copy link
Contributor Author

jontje commented Nov 18, 2020

Synced with the base branch

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pff .. Windows .. 🤷‍♂️ ;)

@jontje jontje merged commit 88e0072 into ros-industrial:master Nov 20, 2020
@jontje
Copy link
Contributor Author

jontje commented Nov 20, 2020

Thanks for the help @traversaro 👍, as well as the approval @gavanderhoorn 👍

@jontje jontje deleted the msvc_proto_export_macro branch November 20, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants