Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rep-0152.rst for orphaned package maintainer info. #150

Open
wants to merge 28 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@k-okada
Copy link

k-okada commented Dec 27, 2017

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Jan 2, 2018

Nitpick: please start each sentence on a new line to avoid huge diffs for small changes.

@k-okada k-okada force-pushed the k-okada:rep152_orphaned branch from e380656 to 0d5b63c Jan 4, 2018

@k-okada k-okada referenced this pull request Jan 16, 2018

Merged

fix for kinetic #19

@v4hn v4hn referenced this pull request Jan 24, 2018

Open

release for kinecik #10

@NikolausDemmel

This comment has been minimized.

Copy link
Contributor

NikolausDemmel commented Feb 10, 2018

👍, REP looks good to me.

I have a few minor comments on language. Would you prefer comments or a PR on your branch?

Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst

1. Updated maintainer section in ``package.xml`` indicating that the package is orphaned and commit to the source tree, before you run the ``catkin_generate_changelog`` command.

2. During ``bloom-release`` process, you will asked to set maintenance status as follows. Choose ``unmaintained`` . ::

This comment has been minimized.

@dirk-thomas

dirk-thomas Feb 12, 2018

Member

Nitpick: wrap before new sentence.

@k-okada k-okada force-pushed the k-okada:rep152_orphaned branch 2 times, most recently from 4b9d536 to 2f993df Feb 15, 2018

@k-okada k-okada force-pushed the k-okada:rep152_orphaned branch from 2f993df to 5e5bc9d Feb 15, 2018

@k-okada

This comment has been minimized.

Copy link
Author

k-okada commented Feb 21, 2018

@NikolausDemmel

This comment has been minimized.

Copy link
Contributor

NikolausDemmel commented Feb 21, 2018

thank you . PR would be better. thanks

Sorry I didn't get to it yet. I'll try to do it soon and send a PR.

Show resolved Hide resolved rep-0152.rst
Show resolved Hide resolved rep-0152.rst
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Valid maintenance statuses:
- developed: active development is in progress
- maintained: no new development, but bug fixes and pull requests are addressed
- unmaintained: looking for new maintainer, bug fixes and pull requests will not be addressed

This comment has been minimized.

@gbiggs

gbiggs Feb 22, 2018

Should probably also mention that when it becomes incompatible with a dependency, it will no longer be released unless someone contributes a patch to fix it.

This comment has been minimized.

@esteve esteve referenced this pull request Nov 28, 2018

Open

ROS Melodic release? #2358

@v4hn

This comment has been minimized.

Copy link

v4hn commented Jan 29, 2019

I believe this initiative is as relevant as two years ago.
It will also become relevant for ROS2 in the not-too-distant future.

It would be nice to see this finally merged. @k-okada @gbiggs @dirk-thomas

@k-okada

This comment has been minimized.

Copy link
Author

k-okada commented Feb 9, 2019

@v4hn Thanks i think this OK to merge @dirk-thomas

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Feb 11, 2019

Before a REP draft is merged it should be announced on Discourse for wider visibility. Since the last communication about this draft has been more than a year ago I think it should happen again.

It might also be good to review the text for spelling and grammar since there seem to be numerous issues like that - starting at the title of the document.

@k-okada

This comment has been minimized.

Copy link
Author

k-okada commented Feb 20, 2019

@dirk-thomas thanks for comments, I have fixed some typos, and annnouced on Discourse
https://discourse.ros.org/t/ros-orphaned-package-maintainer-info-rep-152-for-review/7906

@JWhitleyAStuff
Copy link

JWhitleyAStuff left a comment

Please see my suggestions. They are mostly grammatical changes/fixes.

Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated
Show resolved Hide resolved rep-0152.rst Outdated

JWhitleyAStuff and others added some commits Feb 25, 2019

grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>

JWhitleyAStuff and others added some commits Feb 25, 2019

grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
@k-okada

This comment has been minimized.

Copy link
Author

k-okada commented Feb 25, 2019

@JWhitleyAStuff thanks for fixes. I have updated the PR.

@JWhitleyAStuff

This comment has been minimized.

Copy link

JWhitleyAStuff commented Feb 25, 2019

@JWhitleyAStuff thanks for fixes. I have updated the PR.

It looks like there are still a few more that are unresolved, unless my interface is just not updating. Click the "Load More..." link above under "8 hidden conversations."

JWhitleyAStuff and others added some commits Feb 25, 2019

grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
grammatical changes/fixes by @JWhitleyAStuff
Co-Authored-By: k-okada <k-okada@jsk.t.u-tokyo.ac.jp>
@k-okada

This comment has been minimized.

Copy link
Author

k-okada commented Feb 25, 2019

@JWhitleyAStuff ok, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.