Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tf timeout of image_rotate #382

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

garaemon
Copy link
Contributor

@garaemon garaemon commented Feb 9, 2019

  • If prev_stamp_ is initialized as 0.0, tf may wait for transformation for
    long duration
    for the first time. In order to give up the wait in
    reasonable duration, initialize prev_stamp_ as the current time.

@SteveMacenski
Copy link
Member

@JWhitleyAStuff LGTM, it just effects initialization of the 1st image run through.

@garaemon please rebase this to the melodic-devel branch and we'll merge!

@SteveMacenski SteveMacenski self-requested a review April 10, 2019 17:19
* If prev_stamp_ is initialized as 0.0, tf may wait transformation for
  long duration at the first time. In order to give up the wait in
  reasonable duration, initialize prev_stamp_ as current time.
@garaemon garaemon changed the base branch from indigo to melodic April 11, 2019 04:05
@garaemon
Copy link
Contributor Author

garaemon commented Apr 11, 2019

I've rebased and changed the target branch to melodic.

@JWhitleyWork JWhitleyWork merged commit 983a795 into ros-perception:melodic Apr 11, 2019
@SteveMacenski
Copy link
Member

Thanks for the contribution!

SteveMacenski added a commit that referenced this pull request Apr 11, 2019
Backport of #382: Initialize prev_stamp_ as ros::Timw::now()
generush pushed a commit to generush/image_pipeline that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants