fix the invalid iterator issue #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Wang <daniel.wang@canonical.com>
|
Thanks for helping in improving MoveIt |
davetcoleman
approved these changes
Aug 15, 2019
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
|
Thanks! |
|
@v4hn pointed out that I forgot to wait for a second reviewer, my bad. i think im just used to one reviewer being enough for all the other projects we do, especially when they are as trivial as this. |
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
Signed-off-by: Daniel Wang <daniel.wang@canonical.com>
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Signed-off-by: Daniel Wang <daniel.wang@canonical.com>
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Signed-off-by: Daniel Wang <daniel.wang@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Wang daniel.wang@canonical.com
Description
this pull request address #1578 to avoid
iterator controller_itpoint to random elementsChecklist