Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link transforms before calling checkCollision on robot state in jog_arm #1825

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jan 3, 2020

Description

Fix issue in collision_check_thread in jog_arm where link transforms aren't being updated before call to checkCollision.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Create tests, which fail without this PR reference
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov-io
Copy link

Codecov Report

Merging #1825 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1825      +/-   ##
=========================================
+ Coverage    48.5%   48.5%   +<.01%     
=========================================
  Files         298     298              
  Lines       23302   23303       +1     
=========================================
+ Hits        11302   11303       +1     
  Misses      12000   12000
Impacted Files Coverage Δ
...ntal/moveit_jog_arm/src/collision_check_thread.cpp 90.24% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d867859...55687fe. Read the comment docs.

@mlautman mlautman merged commit 844a021 into moveit:master Jan 3, 2020
@welcome
Copy link

welcome bot commented Jan 3, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@mlautman mlautman deleted the p/tylerjw/update_collision_body_transforms branch January 3, 2020 21:06
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants