Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add planning_adapters for chomp in setup assistant #2242

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

tnaka
Copy link
Contributor

@tnaka tnaka commented Aug 9, 2020

Description

CHOMPPlanner doesn't fill velocity, acc or time in a generated trajectory.
We need AddTimeParameterization to use this planner with ros_control (for gazebo simulation etc.).
I added the same planning adapters as in ompl_planning_pipeline.launch.xml.
As a reference moveit/panda_moveit_config#31 adds these planning adapters in chomp's launch file.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

CHOMPPlanner doesn't fill velocity, acc or time.
We need AddTimeParameterization at least to use this planner with
ros_control.
@tnaka tnaka requested a review from rhaschke as a code owner August 9, 2020 19:17
@welcome
Copy link

welcome bot commented Aug 9, 2020

Thanks for helping in improving MoveIt and open source robotics!

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #2242 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2242      +/-   ##
==========================================
+ Coverage   57.73%   57.79%   +0.06%     
==========================================
  Files         326      326              
  Lines       25629    25629              
==========================================
+ Hits        14797    14813      +16     
+ Misses      10832    10816      -16     
Impacted Files Coverage Δ
...ipulation/pick_place/src/manipulation_pipeline.cpp 76.41% <0.00%> (-0.95%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.10% <0.00%> (+0.09%) ⬆️
...raint_samplers/src/default_constraint_samplers.cpp 82.90% <0.00%> (+0.36%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 79.37% <0.00%> (+0.44%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 73.60% <0.00%> (+0.79%) ⬆️
moveit_core/robot_model/src/joint_model_group.cpp 61.81% <0.00%> (+2.42%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 75.17% <0.00%> (+2.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2924c...f9702ca. Read the comment docs.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@rhaschke rhaschke added the awaits 2nd review one maintainer approved this request label Aug 10, 2020
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. CI failure is independent. I'll merge.

@v4hn v4hn merged commit 576c39c into moveit:master Aug 10, 2020
@welcome
Copy link

welcome bot commented Aug 10, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

rhaschke pushed a commit that referenced this pull request Aug 13, 2020
CHOMPPlanner doesn't fill velocity, acc or time.
We need AddTimeParameterization at least to use this planner with
ros_control.
@rhaschke rhaschke mentioned this pull request Aug 13, 2020
rhaschke pushed a commit that referenced this pull request Aug 13, 2020
CHOMPPlanner doesn't fill velocity, acc or time.
We need AddTimeParameterization at least to use this planner with
ros_control.
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
…2242)

Co-authored-by: Alp Akgun <samialp.akgun@ocado.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits 2nd review one maintainer approved this request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants