-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add planning_adapters for chomp in setup assistant #2242
Add planning_adapters for chomp in setup assistant #2242
Conversation
CHOMPPlanner doesn't fill velocity, acc or time. We need AddTimeParameterization at least to use this planner with ros_control.
Thanks for helping in improving MoveIt and open source robotics! |
Codecov Report
@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
+ Coverage 57.73% 57.79% +0.06%
==========================================
Files 326 326
Lines 25629 25629
==========================================
+ Hits 14797 14813 +16
+ Misses 10832 10816 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. CI failure is independent. I'll merge.
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
CHOMPPlanner doesn't fill velocity, acc or time. We need AddTimeParameterization at least to use this planner with ros_control.
CHOMPPlanner doesn't fill velocity, acc or time. We need AddTimeParameterization at least to use this planner with ros_control.
…2242) Co-authored-by: Alp Akgun <samialp.akgun@ocado.com>
Description
CHOMPPlanner doesn't fill velocity, acc or time in a generated trajectory.
We need AddTimeParameterization to use this planner with ros_control (for gazebo simulation etc.).
I added the same planning adapters as in ompl_planning_pipeline.launch.xml.
As a reference moveit/panda_moveit_config#31 adds these planning adapters in chomp's launch file.
Checklist