Fixed velocities not being set to zero when stale #2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping in improving MoveIt and open source robotics! |
|
Looks good to me. Good catch, thanks! You'll see that the continuous integration tests are failing if you click on the Details for Travis CI. No fault of yours. I think that should be resolved with a PR Robert made recently. Or you can rebase on master and that should cause the tests to run again. |
AndyZe
approved these changes
Aug 13, 2020
|
Also looks good to me! |
rhaschke
approved these changes
Aug 13, 2020
rhaschke
pushed a commit
that referenced
this pull request
Aug 13, 2020
|
"Updating the PR" via github failed. I manually rebased and merged via ad067ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the range-based for loop in
serve_calcs.cppto pass-by-reference such that velocities really are set to zero when stale.Should fix #2254
I hope I am doing the pull request procedure correctly as this is my first time opening a pull request to a larger project. Please feel free to correct me!
Checklist