Auto format codebase using clang-format #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
force-pushed
the
kinetic-devel-clang-format
branch
3 times, most recently
from
318e11c
to
23553fb
Compare
davetcoleman
force-pushed
the
kinetic-devel-clang-format
branch
from
23553fb
to
fc1fc60
Compare
|
This PR is ready to merge now that kinetic has been released! |
|
Welcome to the new age of auto-formatted code :) Shouldn't we apply similar changes to the other two branches to ease further cherry-picking? |
|
Yes, I will do that soon |
|
So beautiful!!! |
This was referenced Oct 22, 2016
|
I've applied the formatting to indigo/jade, see above |
|
...one step closer to robots programming robots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to finalize discussion on the proposed auto-formatting of the code base discussed #242
After this is merged, Travis will then warn us when new code is added that violates the style guidelines: moveit/moveit_ci#19
The changes in this PR are all achieved by the single command in the root of this repo:
Using the formatting file defined in https://github.com/ros-planning/moveit/blob/kinetic-devel/.clang-format