[Hybrid Planning] Improve action cancellation #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
commented
May 24, 2022
...ros/hybrid_planning/global_planner/global_planner_component/src/global_planner_component.cpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1272 +/- ##
==========================================
- Coverage 61.46% 61.44% -0.02%
==========================================
Files 274 274
Lines 24940 24940
==========================================
- Hits 15328 15322 -6
- Misses 9612 9618 +6
Continue to review full report at Codecov.
|
henningkayser
approved these changes
May 24, 2022
...ros/hybrid_planning/global_planner/global_planner_component/src/global_planner_component.cpp
Outdated
Show resolved
Hide resolved
AndyZe
force-pushed
the
andyz/hp_action_server
branch
3 times, most recently
from
b867a26
to
0a82ad1
Compare
AndyZe
force-pushed
the
andyz/hp_action_server
branch
from
ba62041
to
286be41
Compare
zflat
reviewed
May 25, 2022
...ros/hybrid_planning/global_planner/global_planner_component/src/global_planner_component.cpp
Outdated
Show resolved
Hide resolved
AndyZe
force-pushed
the
andyz/hp_action_server
branch
4 times, most recently
from
272edff
to
7bbce45
Compare
added 7 commits
May 31, 2022 14:40
AndyZe
force-pushed
the
andyz/hp_action_server
branch
from
7bbce45
to
e843bda
Compare
|
Can I get a final review? @henningkayser @JafarAbdi |
AndyZe
changed the title
henningkayser
approved these changes
Jun 2, 2022
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Jul 14, 2022
* Small changes to make the action server more performant * Move the threads to member variables * Add a simple cancellation demo * Do not use unique_ptr * Lint * Launch file cleanup * When a new HP goal is received, give the previous some time to cancel * A unique callback group for each action server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action cancellation wasn't working well, so...
Test with:
ros2 launch moveit_hybrid_planning hybrid_planning_demo.launch.pyros2 run moveit_hybrid_planning cancel_actionThis work is sponsored by RE2 Robotics.