-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moveit_core: Remove unnecessary rclcpp.hpp includes #1333
moveit_core: Remove unnecessary rclcpp.hpp includes #1333
Conversation
If anyone is interested in helping, please let me know, we have 37 packages and this PR only touch one :D |
856900f
to
5014e24
Compare
Ok, I did the same for the whole codebase, I got ~286s reduction see https://gist.github.com/JafarAbdi/cd9735c2eb9cdf6e8906e057c9b18590 |
7d1d55d
to
4ed6ecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice change, thank you.
I got ~286s reduction
Wow... Just wow.
|
42f9c7a
to
4551c69
Compare
4551c69
to
3a5732a
Compare
Description
Using https://github.com/aras-p/ClangBuildAnalyzer to profile the compile time for the whole codebase I found out rclcpp.hpp is one of the most expensive headers: https://gist.github.com/JafarAbdi/965b23666d4aeca92990554629b45644
So this PR removes unnecessary rclcpp.hpp includes from moveit_core which result in ~55s reduction in compile time (without parallel build)
Before:
After: