-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PlanarJointModel::satisfiesPositionBounds #1353
Fix PlanarJointModel::satisfiesPositionBounds #1353
Conversation
413d72d
to
2083562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
@rcywongaa Do you mind backporting it to https://github.com/ros-planning/moveit? |
@JafarAbdi Done 😄 |
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
+ Coverage 61.56% 61.57% +0.01%
==========================================
Files 274 274
Lines 24966 24966
==========================================
+ Hits 15369 15370 +1
+ Misses 9597 9596 -1
Continue to review full report at Codecov.
|
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai> (cherry picked from commit 1c3e1ea)
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai> (cherry picked from commit 1c3e1ea)
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai> (cherry picked from commit 1c3e1ea)
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
Description
Fixes
PlanarJointModel::satisfiesPositionBounds
to correctly check for all 3 positions instead of the 0-th position 3 times.Replaces #1327
Checklist