Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlanarJointModel::satisfiesPositionBounds #1353

Conversation

rcywongaa
Copy link
Contributor

@rcywongaa rcywongaa commented Jun 13, 2022

Description

Fixes PlanarJointModel::satisfiesPositionBounds to correctly check for all 3 positions instead of the 0-th position 3 times.

Replaces #1327

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rcywongaa rcywongaa marked this pull request as ready for review June 13, 2022 21:10
@rcywongaa rcywongaa force-pushed the Fix_PlanarJointModel_satisfiesPositionBounds branch from 413d72d to 2083562 Compare June 13, 2022 21:10
Copy link
Contributor

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@JafarAbdi
Copy link
Contributor

@rcywongaa Do you mind backporting it to https://github.com/ros-planning/moveit?

@rcywongaa
Copy link
Contributor Author

@JafarAbdi Done 😄

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1353 (d06d0cb) into main (990925e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   61.56%   61.57%   +0.01%     
==========================================
  Files         274      274              
  Lines       24966    24966              
==========================================
+ Hits        15369    15370       +1     
+ Misses       9597     9596       -1     
Impacted Files Coverage Δ
moveit_core/robot_model/src/planar_joint_model.cpp 84.12% <100.00%> (ø)
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp 73.46% <0.00%> (-3.70%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.73% <0.00%> (+0.44%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.43% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990925e...d06d0cb. Read the comment docs.

@henningkayser henningkayser added backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble labels Jun 16, 2022
@henningkayser henningkayser merged commit 1c3e1ea into moveit:main Jun 16, 2022
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
JafarAbdi pushed a commit that referenced this pull request Jun 16, 2022
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
henningkayser pushed a commit that referenced this pull request Jun 16, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
henningkayser pushed a commit that referenced this pull request Jun 16, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants