Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when named target does not exist #1580

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

rcywongaa
Copy link
Contributor

Description

This avoids hiding the (likely) bug where an incorrect state name is given

Replaces #1579

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 51.11% // Head: 51.10% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8e6c214) compared to base (e960047).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   51.11%   51.10%   -0.01%     
==========================================
  Files         380      380              
  Lines       31796    31796              
==========================================
- Hits        16250    16246       -4     
- Misses      15546    15550       +4     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.29% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

For future reviewers, here's the link to getVariableDefaultPositions:

https://github.com/ros-planning/moveit2/blob/e96004702bbd338a08340eab0985fd04c74968fa/moveit_core/robot_model/src/joint_model_group.cpp#L450

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@henningkayser henningkayser merged commit d64e378 into moveit:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants