Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when named target does not exist #1579

Closed
wants to merge 13 commits into from
Closed

Log when named target does not exist #1579

wants to merge 13 commits into from

Conversation

rcywongaa
Copy link
Contributor

Description

This avoids hiding the (likely) bug where an incorrect state name is given

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

mergify bot and others added 13 commits August 8, 2022 18:37
@mergify
Remove __has_include statements (moveit#1481) (moveit#1483)
df30553
Remove rolling CI from humble (moveit#1484)
70077d2
@ejalaa12 @mergify
automatically declare parameters from overrides
4cd07f3 
(cherry picked from commit b961e9c)
@ejalaa12 @mergify
fix path to constraints parameters
ccce09b 
(cherry picked from commit fb03316)
@ejalaa12 @mergify
correctly initialize rmw_serialized_message_t
963d298 
(cherry picked from commit cf714d5)
@werner291 @mergify
Fixed fabs() use in quaternion interpolation (moveit#1479)
bfa8a83 
* Interpolate using Eigen::Quaternion::slerp() to (hopefully) save us further headaches and take advantage of Eigen probably having a better implementation than us.
* Created a test case that fails for the old version, but passes for the new.

Co-authored-by: AndyZe <zelenak@picknik.ai>
(cherry picked from commit 59e69bb)
@henningkayser
Fixes for using generate_state_database (backport moveit#1412) (movei…
272dbaf 
…t#1493)
@henningkayser
Fixed fabs() use in quaternion interpolation (backport moveit#1479) (m…
3eef088 
…oveit#1496)
@henningkayser
Switch CI target branches to humble (moveit#1497)
299a451
@mergify @henningkayser
Fix callback execution in MGI (backport moveit#1305) (moveit#1462)
5e1c637 
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread.

(cherry picked from commit 042186a)

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
@mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
7dd0434 
…rCode is returned (moveit#1266) (moveit#1460)
@mergify @sjahr
Improve CMake usage (moveit#1550) (moveit#1555)
5a589fc 
Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
@rcywongaa
Log when named target does not exist
34e0ee1
@mergify
Copy link

mergify bot commented Sep 25, 2022

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@rcywongaa rcywongaa changed the base branch from humble to main September 25, 2022 11:25
@mergify
Copy link

mergify bot commented Sep 25, 2022

This pull request is in conflict. Could you fix it @rcywongaa?

@rcywongaa rcywongaa closed this Sep 25, 2022
@rcywongaa rcywongaa mentioned this pull request Sep 25, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rcywongaa @ejalaa12 @werner291 @henningkayser