Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveit_msgs no longer needs to be built from source #1739

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Nov 18, 2022

With the new sync, this shouldn't be necessary any longer.

@tylerjw
Copy link
Member

tylerjw commented Nov 18, 2022

Re-running. Rolling sync should happen today, no idea if it has happened yet.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 50.97% // Head: 50.94% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (8ac8d16) compared to base (99a4a43).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   50.97%   50.94%   -0.03%     
==========================================
  Files         378      378              
  Lines       31658    31658              
==========================================
- Hits        16135    16125      -10     
- Misses      15523    15533      +10     
Impacted Files Coverage Δ
...n/allvalid/collision_detector_allocator_allvalid.h 100.00% <ø> (ø)
...ction_bullet/collision_detector_allocator_bullet.h 100.00% <ø> (ø)
...src/bullet_integration/bullet_cast_bvh_manager.cpp 52.86% <ø> (ø)
...bullet_integration/bullet_discrete_bvh_manager.cpp 50.00% <ø> (ø)
...ion_bullet/src/bullet_integration/bullet_utils.cpp 64.77% <ø> (ø)
.../src/bullet_integration/contact_checker_common.cpp 84.73% <ø> (ø)
...bullet/src/bullet_integration/ros_bullet_utils.cpp 92.86% <ø> (ø)
...n_detection_fcl/collision_detector_allocator_fcl.h 100.00% <ø> (ø)
...on_distance_field/collision_distance_field_types.h 59.19% <ø> (ø)
...sion_distance_field/collision_env_distance_field.h 4.77% <ø> (ø)
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vatanaksoytezer vatanaksoytezer merged commit 6e0fce3 into moveit:main Nov 20, 2022
@vatanaksoytezer vatanaksoytezer added the backport-humble Mergify label that triggers a PR backport to Humble label Nov 20, 2022
mergify bot pushed a commit that referenced this pull request Nov 20, 2022
rhaschke added a commit to rhaschke/moveit2 that referenced this pull request Jan 9, 2023
rhaschke added a commit that referenced this pull request Jan 9, 2023
* Revert #1739: moveit_msgs no longer needs to be built from source
  This reverts commit 6e0fce3.
* Remove obsolete include: moveit_msgs/srv/execute_known_trajectory.hpp
* Cleanup moveit2.repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants