Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use ament_export_targets from package sub folder #1889

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Don't use ament_export_targets from package sub folder #1889

merged 2 commits into from
Jan 26, 2023

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jan 25, 2023

  • Sort exports from moveit_core
  • Install collision_detector_bullet_plugin from moveit_core

Description

Fixes #1858

@tylerjw tylerjw requested a review from rhaschke January 25, 2023 21:02
@tylerjw tylerjw mentioned this pull request Jan 25, 2023
Closed
rhaschke
rhaschke approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI is failing because the docker image is not found. Any idea why?

@tylerjw
Copy link
Member Author

tylerjw commented Jan 25, 2023

Looks good. CI is failing because the docker image is not found. Any idea why?

We've been seeing this failure randomly yesterday and today. We think it might just be GitHub infrastructure.

@henningkayser
Copy link
Member

Looks good. CI is failing because the docker image is not found. Any idea why?

We've been seeing this failure randomly yesterday and today. We think it might just be GitHub infrastructure.

Triggering the docker builds and then CI again fixed it today. It was probably just a GitHub thing.

@henningkayser henningkayser added the backport-humble Mergify label that triggers a PR backport to Humble label Jan 26, 2023
@henningkayser henningkayser merged commit b1e8b2d into moveit:main Jan 26, 2023
@mergify mergify bot mentioned this pull request Jan 26, 2023
Merged
@tylerjw tylerjw deleted the ament_export_target_from_root branch January 26, 2023 16:09
@clalancette clalancette mentioned this pull request Mar 24, 2023
Closed
tylerjw pushed a commit that referenced this pull request Aug 23, 2023
@mergify
Don't use ament_export_targets from package sub folder (backport #1889)…
b9ef75d 
… (#1893)
This was referenced Oct 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@rhaschke rhaschke rhaschke approved these changes

@AndyZe AndyZe AndyZe approved these changes

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

Assignees
No one assigned
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong use of ament_export_targets from package sub folders
5 participants
@tylerjw @henningkayser @rhaschke @AndyZe @ChrisThrasher