Change filter coefficient to ROS param #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahiminfinite
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
+ Coverage 50.84% 50.92% +0.08%
==========================================
Files 391 391
Lines 32147 32129 -18
==========================================
+ Hits 16343 16358 +15
+ Misses 15804 15771 -33
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Abishalini
reviewed
Apr 10, 2023
ibrahiminfinite
force-pushed
the
ibrahim/param_coeff
branch
from
843b527
to
e417c1e
Compare
ibrahiminfinite
force-pushed
the
ibrahim/param_coeff
branch
from
b94c88f
to
5b93e24
Compare
|
This should be done now. |
Abishalini
approved these changes
Apr 10, 2023
AndyZe
reviewed
Apr 10, 2023
ibrahiminfinite
commented
Apr 10, 2023
ChrisThrasher
suggested changes
Apr 10, 2023
3 tasks
ibrahiminfinite
commented
Apr 11, 2023
ibrahiminfinite
force-pushed
the
ibrahim/param_coeff
branch
from
e34ceb5
to
076bf81
Compare
AndyZe
reviewed
Apr 11, 2023
AndyZe
approved these changes
Apr 11, 2023
|
Happy to contribute! |
1 task
andrey-pr
added a commit
to KanRobotics/moveit2
that referenced
this pull request
Apr 21, 2023
AndyZe
added a commit
that referenced
this pull request
May 8, 2023
* Added butterworth_filter_coeff parameter * Added formating like in original PR #2091 * Update moveit_core/online_signal_smoothing/src/butterworth_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/online_signal_smoothing/include/moveit/online_signal_smoothing/butterworth_filter.h Co-authored-by: AndyZe <andyz@utexas.edu> * Alphabetized dependencies * Update moveit_core/package.xml Co-authored-by: AndyZe <andyz@utexas.edu> --------- Co-authored-by: andrey <> Co-authored-by: AndyZe <andyz@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Butterworth filter coefficient into a ROS param.
Fixes #2089
Checklist