-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change filter coefficient to ROS param #2091
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
+ Coverage 50.84% 50.92% +0.08%
==========================================
Files 391 391
Lines 32147 32129 -18
==========================================
+ Hits 16343 16358 +15
+ Misses 15804 15771 -33
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment. Otherwise this PR looks good to me. Thanks!
843b527
to
e417c1e
Compare
b94c88f
to
5b93e24
Compare
This should be done now. |
e34ceb5
to
076bf81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Thanks for your patience with the review process.
Happy to contribute! |
* Added butterworth_filter_coeff parameter * Added formating like in original PR #2091 * Update moveit_core/online_signal_smoothing/src/butterworth_filter.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/online_signal_smoothing/include/moveit/online_signal_smoothing/butterworth_filter.h Co-authored-by: AndyZe <andyz@utexas.edu> * Alphabetized dependencies * Update moveit_core/package.xml Co-authored-by: AndyZe <andyz@utexas.edu> --------- Co-authored-by: andrey <> Co-authored-by: AndyZe <andyz@utexas.edu>
Description
This PR makes the Butterworth filter coefficient into a ROS param.
Fixes #2089
Checklist