Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include optional in pose_tracking #406

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

JafarAbdi
Copy link
Member

Description

CI is failing for not being able to find boost::optional see

/home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_ros/moveit_servo/include/moveit_servo/pose_tracking.h:193:10: error: ‘optional’ in namespace ‘boost’ does not name a template type; did you mean ‘conditional’?

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it would be cool if you alphabetize the includes

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #406 (ed95058) into main (855db9e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   53.04%   53.04%   +0.01%     
==========================================
  Files         212      212              
  Lines       22612    22612              
==========================================
+ Hits        11992    11993       +1     
+ Misses      10620    10619       -1     
Impacted Files Coverage Δ
...bot_model/include/moveit/robot_model/robot_model.h 92.86% <ø> (ø)
...bot_state/include/moveit/robot_state/robot_state.h 88.89% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.24% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c207db9...ed95058. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 44e71eb into moveit:main Mar 30, 2021
@JafarAbdi JafarAbdi deleted the pr-include_boost_optional branch March 30, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants