Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete exclusive arg for collision detector creation #466

Merged
merged 3 commits into from
May 21, 2021

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented May 19, 2021

PR #364 removed the ability to have multiple collision detectors simultaneously, so we don't need this exclusive arg anymore.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #466 (4c2520b) into main (4bdb3c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files         218      218           
  Lines       22987    22987           
=======================================
  Hits        11230    11230           
  Misses      11757    11757           
Impacted Files Coverage Δ
.../collision_plugin_loader/collision_plugin_loader.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdb3c5...4c2520b. Read the comment docs.

@AndyZe AndyZe changed the title Delete exclusive arg for collision detector creation WIP: Delete exclusive arg for collision detector creation May 21, 2021
@AndyZe AndyZe changed the title WIP: Delete exclusive arg for collision detector creation Delete exclusive arg for collision detector creation May 21, 2021
@AndyZe AndyZe merged commit e090a73 into moveit:main May 21, 2021
DLu pushed a commit to DLu/moveit2 that referenced this pull request May 28, 2021
* Delete exclusive arg for collision detector creation

* Rename setActiveCollisionDetector->allocateCollisionDetector everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants