Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation and cleanup of TOTG plugin #584

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Jul 31, 2021

Pulling some changes out of #571 so they can be merged separately.

  • Document some limitations of TOTG in the plugin description.
  • Minor code cleanup.
  • Mark iterative spline and iterative parabola plugins as deprecated since they have some known issues (Trajectory smoothness moveit#1711).

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #584 (e0fcf2e) into main (db371e0) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   46.97%   46.98%   +0.01%     
==========================================
  Files         185      185              
  Lines       19657    19655       -2     
==========================================
+ Hits         9231     9232       +1     
+ Misses      10426    10423       -3     
Impacted Files Coverage Δ
...cessing/src/time_optimal_trajectory_generation.cpp 77.10% <80.00%> (-0.09%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.85% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db371e0...e0fcf2e. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, approve this PR. Thank you for separating out this small change! 🚀

@AndyZe AndyZe merged commit 8dc55a2 into moveit:main Aug 9, 2021
christianlandgraf pushed a commit to christianlandgraf/moveit2 that referenced this pull request Aug 12, 2021
* Minor documentation and cleanup of TOTG plugin

* Remove deprecation comments

* Add anonymous namespace

Co-authored-by: Tyler Weaver <tyler@picknik.ai>
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Aug 27, 2021
* Minor documentation and cleanup of TOTG plugin

* Remove deprecation comments

* Add anonymous namespace

Co-authored-by: Tyler Weaver <tyler@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants