Delete duplicate entry in Servo launch file #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
commented
Sep 17, 2021
| @@ -125,17 +125,6 @@ def generate_launch_description(): | |||
| name="static_tf2_broadcaster", | |||
| parameters=[{"child_frame_id": "/panda_link0", "frame_id": "/world"}], | |||
| ), | |||
| ComposableNode( | |||
There was a problem hiding this comment.
Could we add a comment explaining why we are launching servo server as a separate node?
Also should we delete the comment block "# Example of launching Servo as a node component" ?
There was a problem hiding this comment.
I added some better comments 👍
Codecov Report
@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 54.17% 54.16% -0.00%
==========================================
Files 192 192
Lines 20180 20180
==========================================
- Hits 10930 10929 -1
- Misses 9250 9251 +1
Continue to review full report at Codecov.
|
henningkayser
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small mistake from #621. Probably mine.