-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use emulated time in action-based controller #899
Conversation
Hi @galou thanks a lot for the contributions!
We should update the documentation on this, it was a recent effort we have taken to merge everything to main and backport if there are no API / ABI breaks.
|
Oh, also CI seems broken right now (not related to your PR), I'm working on fixing it. |
@vatanaksoytezer thanks for offering your help. I start the discussion here, please write me if it should continue elsewhere. The error I get with Rolling is:
|
I bet that is because you need a newer version of moveit_msgs. Currently in ros2 if you have a package installed (into /opt) and have it in your workspace it doesn't correctly use the one in your workspace which can cause errors like this. Assuming you have moveit_msgs in your workspace, try uninstalling it with apt and re-building.
This is something that is on the Humble roadmap and should hopefully be fixed soon in colcon in a way that can work even if you can't upgrade to Humble right away. |
The issue with |
@galou there seems a few legitimate build errors on this PR in CI, do you mind fixing them? I think this is a really nice PR that we would like to merge soon. |
Codecov ReportBase: 50.95% // Head: 50.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 50.95% 50.95%
=======================================
Files 378 378
Lines 31658 31658
=======================================
Hits 16129 16129
Misses 15529 15529
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@galou do you mind running pre-commit for this PR? I think it all looks good, we just need the correct formatting to merge. |
The pre-commit hook was not configured on my system, sorry. |
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
We need to keep track of the node in order to get the time from it. Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
1cd6668
to
dda3877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased these changes and tested them locally, and they seem to work. Approving and merging assuming CI passes.
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
@tylerjw let's not jump the gun. 2 reviews needed. Hopefully I'll approve soon. |
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
ac3e83b
to
fda1223
Compare
(cherry picked from commit b6fcac8) # Conflicts: # moveit_plugins/moveit_simple_controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
(cherry picked from commit b6fcac8)
(cherry picked from commit b6fcac8)
Signed-off-by: Gaël Écorchard gael.ecorchard@cvut.cz
Description
future.wait_for()
should not be used with a time obtained fromnode_->now()
because of the mix between simulated and system time. This PR fix the issue that the action server would time out with a very slow simulated time.Note that for technical reasons (cf. below) I cannot compile
main
but that same changes compile when based onfoxy
.PS: can someone point me to the documentation to test a PR on the
main
branch? I use Foxy and I'm struggling with compiling themain
branch. The documentation states that I could base my PR onfoxy
but my last PR was rejected because of this.Checklist