Update gradient_path.cpp #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update this to fix the equivalent line in navfn too |
|
I've changed the same place to the navfn code. I'm new to git, so is this the correct operation to add one more commits? |
|
@DLu -- is your comment an approval of this fix? If so, I will merge and forward port to K+L |
DLu
pushed a commit
to DLu/navigation
that referenced
this pull request
Nov 16, 2017
* Update gradient_path.cpp * Update navfn.cpp
Merged
DLu
pushed a commit
to DLu/navigation
that referenced
this pull request
Nov 16, 2017
* Update gradient_path.cpp * Update navfn.cpp
DLu
added a commit
that referenced
this pull request
Nov 30, 2017
* Update gradient_path.cpp (#576) * Update gradient_path.cpp * Update navfn.cpp * Only do a getRobotPose when no start pose is given (#628) Omit the unnecessary call to getRobotPose when the start pose was already given, so that move_base can also generate a path in situations where getRobotPose would fail. This is actually to work around an issue of getRobotPose randomly failing.
DLu
added a commit
that referenced
this pull request
Nov 30, 2017
* Respect planner_frequency intended behavior (#622) * Only do a getRobotPose when no start pose is given (#628) Omit the unnecessary call to getRobotPose when the start pose was already given, so that move_base can also generate a path in situations where getRobotPose would fail. This is actually to work around an issue of getRobotPose randomly failing. * Update gradient_path.cpp (#576) * Update gradient_path.cpp * Update navfn.cpp * update to use non deprecated pluginlib macro (#630) * update to use non deprecated pluginlib macro * multiline version as well * Print SDL error on IMG_Load failure in server_map (#631)
gerkey
pushed a commit
to codebot/navigation
that referenced
this pull request
Jan 19, 2018
* Update gradient_path.cpp (ros-planning#576) * Update gradient_path.cpp * Update navfn.cpp * Only do a getRobotPose when no start pose is given (ros-planning#628) Omit the unnecessary call to getRobotPose when the start pose was already given, so that move_base can also generate a path in situations where getRobotPose would fail. This is actually to work around an issue of getRobotPose randomly failing.
johaq
pushed a commit
to CentralLabFacilities/navigation
that referenced
this pull request
Mar 30, 2018
* Update gradient_path.cpp (ros-planning#576) * Update gradient_path.cpp * Update navfn.cpp * Only do a getRobotPose when no start pose is given (ros-planning#628) Omit the unnecessary call to getRobotPose when the start pose was already given, so that move_base can also generate a path in situations where getRobotPose would fail. This is actually to work around an issue of getRobotPose randomly failing.
dantwinkler
added a commit
to 6RiverSystems/navigation
that referenced
this pull request
Mar 2, 2019
From ros-planning PR: ros-planning#576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct an obvious error at line 285