Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tf2 #317

Closed
wants to merge 2 commits into from
Closed

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Mar 8, 2015

This is a replacement for indigo of #298, which was for hydro.

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 8, 2015

All the fixes needed upstream to get that code to compile went through but you still need those two merge requests to get tests to pass:

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 8, 2015

and btw, the main motivation for tf2 is to remove the PCL dependency (which will be the next merge request : vrabaud@28b3981 )

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 15, 2015

should I close that pull request and re-open it for Jade only ?

@mikeferguson
Copy link
Contributor

We can leave this one open -- but please open a PR for Jade and then if we end up backporting we will already have this PR for the backport to indigo.

@mikeferguson
Copy link
Contributor

@vrabaud with PR79 merged, 83 looks like it is only for bag files -- this is probably ready for on-robot testing? If so I'll get one my folks to test it out.

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 19, 2015

indeed, go ahead !

@vrabaud vrabaud force-pushed the indigo-devel branch 3 times, most recently from c178bc6 to 846ffd8 Compare March 19, 2015 21:12
@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 19, 2015

I had to make a few more commits because of some build failures when cherry-picking for Jade. Nothing major, it's all good to go but I have to say that the amcl tests do not pass on Jade...

@vrabaud
Copy link
Contributor Author

vrabaud commented Mar 22, 2015

I had forgotten to install a Python package .... everything's fine and cherry-pickable for jade on my side.

@vrabaud vrabaud mentioned this pull request Mar 26, 2015
This is to get test_rosie_multilaser.xml to work
@vrabaud
Copy link
Contributor Author

vrabaud commented Apr 19, 2015

all the upstream bugs in tf2 got fixed. Have you guys had time to test ? I just rebased.
I know it's a scary change but if you just look line by line, you'll see the changes are pretty trivial at 95%.
We can also just focus on Jade of course.

@vrabaud
Copy link
Contributor Author

vrabaud commented May 9, 2015

Let's just focus on Jade and #322

@vrabaud vrabaud closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants