-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to tf2 #317
Switch to tf2 #317
Conversation
All the fixes needed upstream to get that code to compile went through but you still need those two merge requests to get tests to pass: |
and btw, the main motivation for tf2 is to remove the PCL dependency (which will be the next merge request : vrabaud@28b3981 ) |
should I close that pull request and re-open it for Jade only ? |
We can leave this one open -- but please open a PR for Jade and then if we end up backporting we will already have this PR for the backport to indigo. |
@vrabaud with PR79 merged, 83 looks like it is only for bag files -- this is probably ready for on-robot testing? If so I'll get one my folks to test it out. |
indeed, go ahead ! |
c178bc6
to
846ffd8
Compare
I had to make a few more commits because of some build failures when cherry-picking for Jade. Nothing major, it's all good to go but I have to say that the amcl tests do not pass on Jade... |
I had forgotten to install a Python package .... everything's fine and cherry-pickable for jade on my side. |
This is to get test_rosie_multilaser.xml to work
all the upstream bugs in tf2 got fixed. Have you guys had time to test ? I just rebased. |
Let's just focus on Jade and #322 |
This is a replacement for indigo of #298, which was for hydro.