-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gazebo9] Added reflectance callback to publish reflectance image in ROS #1046
[Gazebo9] Added reflectance callback to publish reflectance image in ROS #1046
Conversation
could you update the plugin params in the PR description? i.e. it now expects |
I didn't know I can just edit your comment in the PR. I just updated it (the first comment in the conversation) |
yes, I think it's a visualization matter. I got the same image |
friendly ping @chapulina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have a nitpick about documentation. Also note that the upstream PR must be merged first.
gazebo_plugins/include/gazebo_plugins/gazebo_ros_depth_camera.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Hi guys, and sorry for breaking in into a long merged PR, but I'm not being able to run this example. Particularly, what I'm doing is:
And on a separate terminal I'm running I'm running ROS noetic with gazebo_ros_pkgs (v 2.9.2-1focal.20211007.215718), all installed from debians via apt. Any suggestions would be welcome! |
…ROS (ros-simulation#1046) * Added reflectance callback to publish reflectance image in ROS * removed debug trace ros_depth_camera * update reflectance_plugin tag from material to reflectance_map * fixed index variable * Added documentation and override Signed-off-by: ahcorde <ahcorde@gmail.com> * updating reflectance_map tags Signed-off-by: ahcorde <ahcorde@gmail.com>
Moved this PR #1044 to
noetic-devel
to avoid ABI changes in melodicRefletance must be an image.
To include the reflectance: