fix: modify some tests #1380
Merged
fix: modify some tests #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobperron @j-rivero Could you review this PR? |
|
so the |
|
This overlaps with #1355 Also, I'm proposing a change to ament_cpplint to fix a bug where .hh files are considered C system headers (which may affect this PR): ament/ament_lint#374 |
I think this is only a workaround, to trick cpplint into thinking they are not C system headers. After ament/ament_lint#374, using double-quotes shouldn't be necessary. |
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
How about once ignoring cpplint include order until ament/ament_lint#374 is merged? |
Sounds good to me. Thanks for working on it! |
added 2 commits
May 5, 2022 04:28
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
jacobperron
reviewed
May 4, 2022
added 2 commits
May 5, 2022 15:10
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
wep21
commented
May 5, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
May 5, 2022
|
Looks like there are some, unrelated, flaky tests. I'll try triggering CI one more time. |
|
@ros-pull-request-builder retest this please |
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
jacobperron
approved these changes
May 6, 2022
jacobperron
added a commit
that referenced
this pull request
May 11, 2022
Partial backport of #1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 11, 2022
Partial backport of #1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
reviewed
May 11, 2022
| @@ -162,7 +162,7 @@ void GazeboRosInit::Load(int argc, char ** argv) | |||
| // the simulation is paused), late subscribers can receive the previously published message(s). | |||
| impl_->clock_pub_ = impl_->ros_node_->create_publisher<rosgraph_msgs::msg::Clock>( | |||
| "/clock", | |||
| rclcpp::QoS(rclcpp::KeepLast(10)).transient_local()); | |||
| rclcpp::ClockQoS()); | |||
There was a problem hiding this comment.
I'm having second thoughts about this change; I didn't realize the durability setting for rclcpp::ClockQoS is volatile (instead of transient local). I think it might be better to revert this change so we keep the same behavior for anyone depending on the behavior from early versions.
jacobperron
added a commit
that referenced
this pull request
May 11, 2022
Partial backport of #1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
afonsofonbraga
pushed a commit
to afonsofonbraga/gazebo_ros_pkgs
that referenced
this pull request
Aug 4, 2022
Partial backport of ros-simulation#1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
GB255
pushed a commit
to brisa-robotics/gazebo_ros_pkgs
that referenced
this pull request
Aug 5, 2022
* fix: limits of steering speed control * gazebo_plugins: GPS sensor plugin publishing velocity (ros-simulation#1371) (ros-simulation#1386) * GPS sensor publishing velocity Added velocity publisher to GPS sensor plugin. Velocity is published as Vector3Stamped message in ENU coordinates. Since Foxy supports Gazebo 11 by default, GPS sensor implements VelocityEast, VelocityNorth and VelocityUp methods that allow for velocity simulation. * GPS sensor velocity tests Testing velocity messages provided by GPS plugin. Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com> * gazebo_ros: Add inline keyword to template definitions (ros-simulation#1367) * gazebo_ros: Add inline keyword to template definitions * Uncrustify Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Gerard Heshusius <gHeshusius@lely.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> * Use shell=False in when launching gazebo (ros-simulation#1384) Signed-off-by: Aditya <aditya050995@gmail.com> * Fix sim time test (ros-simulation#1390) Partial backport of ros-simulation#1380. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Marcel Dudek <43888122+MarcelDudek@users.noreply.github.com> Co-authored-by: Gerard Heshusius <gh.heshusius@gmail.com> Co-authored-by: Gerard Heshusius <gHeshusius@lely.com> Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Minipada
pushed a commit
to brisa-robotics/gazebo_ros_pkgs
that referenced
this pull request
Nov 13, 2022
* fix: ignore include order for cpplint * gazebo_ros: fix ament_flake8 complaints * fix clock qos * fix flake8 * suppress cmake warnings * remove test for use sim time logic Co-authored-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify some header include orders and change some brackets to double quotes to pass the cpplint test.