Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build on Ubuntu Artful. #715

Merged
merged 1 commit into from
May 9, 2018
Merged

Fix the build on Ubuntu Artful. #715

merged 1 commit into from
May 9, 2018

Conversation

clalancette
Copy link
Contributor

Artful has some bugs in its cmake files for Simbody that
cause it to fail the build. If we are on artful, remove
the problematic entries.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@j-rivero FYI; this should fix the remaining problems on Melodic, so review/merge/release would be appreciated, thanks.

Artful has some bugs in its cmake files for Simbody that
cause it to fail the build.  If we are on artful, remove
the problematic entries.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@j-rivero
Copy link
Contributor

j-rivero commented May 9, 2018

@osrf-jenkins run tests please

@j-rivero
Copy link
Contributor

j-rivero commented May 9, 2018

Summary of the fails:

  • ROS repo a couple of warnings, I'll fix them in a different PR.
  • ros_gazebo_pkgs pr_any has two failing test unrelated to this PR.
  • ros_gazebo_pkgs pr_regression uses a repository which has not been migrated to Melodic.

@j-rivero j-rivero merged commit a08a07b into ros-simulation:melodic-devel May 9, 2018
@j-rivero
Copy link
Contributor

j-rivero commented May 9, 2018

Thanks for the fix Chris!

cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
Artful has some bugs in its cmake files for Simbody that
cause it to fail the build.  If we are on artful, remove
the problematic entries.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants