Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnaissance demo tutorial #19

Closed
wants to merge 11 commits into from
Closed

Reconnaissance demo tutorial #19

wants to merge 11 commits into from

Conversation

vmayoral
Copy link
Contributor

Add preliminar files for the reconnaissance demo tutorial.

@vmayoral
First iteration on reconnaissance demo
c8ebc82 
- Add aztarna (from source for development)
- Add configuration files for demo
- Add README.md instructions
@vmayoral
reconnaissance demo update
1aa3664 
- Update Dockerfile
- Complete README.md
- Update dir naming
@vmayoral
Copy link
Contributor Author

ping @thomas-moulard

@vmayoral
Copy link
Contributor Author

Reviewed and fixed the issue with the working directory (thanks @ruffsl :)!). @thomas-moulard could you please review it again?

ruffsl
ruffsl reviewed Oct 21, 2019
View reviewed changes
README.md Show resolved Hide resolved
ruffsl
ruffsl requested changes Oct 22, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
ruffsl
ruffsl reviewed Oct 22, 2019
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
vmayoral and others added 5 commits October 24, 2019 16:20
@vmayoral @ruffsl
Update README.md
bd1fe57 
Co-Authored-By: Ruffin <roxfoxpox@gmail.com>
@vmayoral @ruffsl
Update README.md
918ec3d 
Co-Authored-By: Ruffin <roxfoxpox@gmail.com>
@vmayoral @ruffsl
Update README.md
4a404cf 
Co-Authored-By: Ruffin <roxfoxpox@gmail.com>
@vmayoral
Optimize cache with changes,
82b2cd6 
Attend https://github.com/ros-swg/turtlebot3_demo/pull/19/files/fb054e1478e74ec9156ff360d68eb6df4ec558fa#r337690173
@vmayoral
Further improve reconnaissance section
1dc4263 
Address comments and reviews. Credit to @ruffsl
@vmayoral vmayoral mentioned this pull request Oct 24, 2019
Closed
@vmayoral
Copy link
Contributor Author

I reproduced everything and there're some issues with the secure demos. See #29

@ruffsl
Copy link
Collaborator

ruffsl commented Oct 24, 2019

Perhaps you'd like to rebase from #30 and test the rebuilt image again?

@vmayoral
Copy link
Contributor Author

Rebased and retested. After merging #30 things fine to me @ruffsl.

@ruffsl, @mikaelarguedas and @thomas-moulard, PTAL. If everyone's fine with it, can you please merge this and I'll do yet another review on top of master?

@mikaelarguedas
Copy link
Collaborator

This branch conflicts with master preventing me from rebasing it on top of master for testing.
@vmayoral could you please update this branch with a rebased version of this PR ? thanks!

@vmayoral
Copy link
Contributor Author

This branch conflicts with master preventing me from rebasing it on top of master for testing.
@vmayoral could you please update this branch with a rebased version of this PR ? thanks!

Thanks for reviewing @mikaelarguedas. Interesting! I get the following which made me think that no conflicts applied

imagen

All right, let me rework this.

@vmayoral
Copy link
Contributor Author

Follows at #31

@vmayoral vmayoral closed this Oct 25, 2019
ruffsl added a commit that referenced this pull request Oct 26, 2019
@ruffsl
Merge pull request #31 from vmayoral/rework
1a13f57 
Reconnaissance demo tutorial, rework of #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas left review comments

@ruffsl ruffsl ruffsl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmayoral @ruffsl @mikaelarguedas