Fix import of external private repos and add private repo test #597
Conversation
christophebedard
requested review from
Karsten1987 and
jaisontj
and removed request for
a team
| required-ros-distributions: foxy | ||
| - uses: ./ | ||
| with: | ||
| import-token: ${{ secrets.TOKEN_PRIVATE_REPO_TEST }} |
There was a problem hiding this comment.
i think you may be able to just use GITHUB_TOKEN here?
There was a problem hiding this comment.
I'll try but from what I can tell it doesn't work.
There was a problem hiding this comment.
yeah I don't think it works. From what I can tell GITHUB_TOKEN is for the current repo only.
There was a problem hiding this comment.
@emersonknapp @christophebedard Hello, thank you for working on this feature!
I've forked and tested this in kenji-miyake#2.
As @christophebedard says, GITHUB_TOKEN is for the current repo and couldn't be overridden.
So I generated a personal token from here and added it as secrets.ACTION_ROS_CI_TOKEN from here.
After that, CI seems to succeed.
In ros-tooling org, I believe a personal token can be replaced with organization secrets or something else.
There was a problem hiding this comment.
@kenji-miyake thanks for confirming!
Since this PR actually contains both a test and a fix for private repos, we should get this merged!
@emersonknapp could you look into creating an organization secret and adding it to this repo as TOKEN_PRIVATE_REPO_TEST? I can't do it (since I'm not an owner I think).
There was a problem hiding this comment.
Organization Secrets are just a way to set a Secret at the level of the Organization, which individual repositories can then use. The contents of the secret itself are still a personal access token. I don't see a need for this particular token to be used outside this test - so I've added it just to this repo. It has "repo" permissions only - so it should be able to check out private repositories.
I updated the branch which is restarting the workflows - we'll see what happens when the queue clears out. Thanks for bumping that dependabot config down to weekly - what a hassle this backed up queue is. I'm still investigating more ways to thin it out even further.
There was a problem hiding this comment.
the test passed! 🎊
but now the branch is out of date 😆 is there any way to override that setting and squash+rebase anyway?
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
- Coverage 39.20% 38.52% -0.68%
==========================================
Files 2 2
Lines 227 231 +4
Branches 44 46 +2
==========================================
Hits 89 89
- Misses 138 142 +4
Continue to review full report at Codecov.
|
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
add-private-repo-test
branch
from
5762481
to
0111635
Compare
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
This reverts commit 16180de. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
add-private-repo-test
branch
from
0111635
to
c832856
Compare
christophebedard
changed the title
Closes #270
This adds a test that uses
import-tokenalong with a repos file with a private repo.It also switches to a different approach for using the
import-tokenglobally. This should hopefully fix all remaining private repo issues.Supersedes #592 (see comments)
Signed-off-by: Christophe Bedard bedard.christophe@gmail.com