-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'x-access-token:' to support GITHUB_TOKEN #692
Add 'x-access-token:' to support GITHUB_TOKEN #692
Conversation
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
- Coverage 49.38% 48.55% -0.83%
==========================================
Files 2 2
Lines 243 243
Branches 53 53
==========================================
- Hits 120 118 -2
- Misses 123 125 +2
Continue to review full report at Codecov.
|
I tested this on my side as well. Since there are a few different possible configurations/setups, here is a table:
Does that look okay @kenji-miyake? I think we should change the "private repos" section of the README here https://github.com/ros-tooling/action-ros-ci#Use-with-private-repos to:
|
@christophebedard Yes, it looks good. Should I change the README? |
please! 😄 you can just copy-paste what I wrote above if you want |
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@christophebedard I'm sorry to be late, done! |
no worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The private repo test was skipped because this PR is coming from a fork, but we both tested it and it works.
Thank you for the contribution!
Resolves #691
As @christophebedard has checked, added
x-access-token
.#691 (comment)
Tested in my repository. (Changed to public after testing in private.)
kenji-miyake/action-ros-ci-test-private#4