Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Allow user to skip rosdep collection #140

Closed
3 tasks done
emersonknapp opened this issue Feb 12, 2020 · 0 comments · Fixed by #177
Closed
3 tasks done

Allow user to skip rosdep collection #140

emersonknapp opened this issue Feb 12, 2020 · 0 comments · Fixed by #177
Assignees
@snehaldb90
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Sprint #16

Comments

@emersonknapp
Copy link
Contributor

emersonknapp commented Feb 12, 2020 •
edited
Loading

Description

As a time optimization in the build process, allow the user to skip collecting rosdeps. It can take about 10s to run rosdep update and when working on code without changing dependencies, it is not necessary every time.

This would be a "power-user feature"

Related Issues

Depends on #139

Completion Criteria

  • User can explicitly skip collecting rosdeps via a CLI flag
  • If the cc_internals/install_rosdeps.sh script doesn't exist already, raise an exception
  • Appropriate documentation exists on the flag to warn about the problems it can cause when used incorrectly. Something like "NOTE: This is an optimization feature for incremental builds to save time running rosdep update - you must have run without this flag at least once to collect the initial dependencies. It has undefined behavior if you change the dependencies of your workspace."

Implementation Notes / Suggestions

Just need a bool CLI flag to pass to the cross_compile pipeline and put the rosdep step in an if-block

Testing Notes / Suggestions

Add a unit test!
@emersonknapp emersonknapp added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2020
@emersonknapp emersonknapp added this to the Sprint #15 milestone Mar 19, 2020
@emersonknapp emersonknapp mentioned this issue Mar 27, 2020
Closed
snehaldb90 pushed a commit to aws-ros-dev/cross_compile that referenced this issue Mar 27, 2020
cross_compile_issue ros-tooling#140 - Allow user to skip rosdep colle…
a4df569 
…ction

Implemented a cross compile feature that allow user to skip ros dependencies.
@lukicdarkoo lukicdarkoo mentioned this issue Mar 27, 2020
Closed
@snehaldb90 snehaldb90 mentioned this issue Mar 27, 2020
Merged
snehaldb90 pushed a commit to aws-ros-dev/cross_compile that referenced this issue Mar 28, 2020
cross_compile_issue ros-tooling#140 - Allow user to skip rosdep colle…
5e4d6d1 
…ction

Implemented a cross compile feature that allow user to skip ros dependencies.

Signed-off-by: Ubuntu <ubuntu@ip-172-31-13-156.us-east-2.compute.internal>
@thomas-moulard thomas-moulard removed this from the Sprint #15 milestone Mar 30, 2020
snehaldb90 pushed a commit to aws-ros-dev/cross_compile that referenced this issue Mar 30, 2020
cross_compile_issue ros-tooling#140 - Allow user to skip rosdep colle…
54dc453 
…ction

Implemented a cross compile feature that allow user to skip ros dependencies.

Signed-off-by: Ubuntu <ubuntu@ip-172-31-13-156.us-east-2.compute.internal>
@emersonknapp emersonknapp added this to the Sprint #16 milestone Mar 30, 2020
snehaldb90 pushed a commit to aws-ros-dev/cross_compile that referenced this issue Mar 30, 2020
@snehaldb90
cross_compile_issue ros-tooling#140 - Allow user to skip rosdep colle…
b250cd6 
…ction

Implemented a cross compile feature that allow user to skip ros dependencies.

Signed-off-by: Snehal Bichkar <snehaldb@amazon.com>
emersonknapp pushed a commit that referenced this issue Mar 30, 2020
@snehaldb90
cross_compile_issue #140 - Allow user to skip rosdep collection (#177)
3cb07b7 
Implemented a cross compile feature that allow user to skip ros dependencies.

Signed-off-by: Snehal Bichkar <snehaldb@amazon.com>
@emersonknapp emersonknapp reopened this Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@snehaldb90 snehaldb90

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Sprint #16
3 participants
@thomas-moulard @emersonknapp @snehaldb90