Install executable rqt_graph #49

jacobperron · 2020-07-28T00:20:43Z

This fixes a regression introduced in #42.

Now the application can be started with 'rqt_graph' or with 'ros2 run'

This fixes a regression introduced in #42. Now the application can be started with 'rqt_graph' or with 'ros2 run' Signed-off-by: Jacob Perron <jacob@openrobotics.org>

ivanpauno · 2020-07-28T13:23:45Z

setup.py

@@ -12,6 +12,7 @@
        ('share/' + package_name + '/resource', ['resource/RosGraph.ui']),
        ('share/' + package_name, ['package.xml']),
        ('share/' + package_name, ['plugin.xml']),
+        ('bin', ['bin/rqt_graph']),


This is not installing an executable, but a Python script.
Thus, it's not runnable on Windows.

I'm not sure if there's a better alternative.

The entry point, which will result in an actual executable on Windows, needs to go to bin and the custom script to be invoked by ros2 run needs to be installed to lib/<pkgname>.

I've reverted #42 (f3d688f) so the entry point goes to bin and installed the new script to lib/rqt_graph for ros2 run to find (a6b3654).

This new approach looks better to me.
I would actually prefer to install an executable in both places, but I'm not sure if that's possible with setuptools.

I would actually prefer to install an executable in both places

Can you explain why that would be better? (Beside the desire to have it be the same.)

I'm not sure if that's possible with setuptools.

I am not aware of a way to achieve that (excluding using custom setuptools commands for it).

Installing scripts instead of executables is sometimes problematic, e.g.: you have to use special code in launch.
See ros2/demos#374.

IMHO: We should never install scripts (neither in bin/ nor lib/<package_name>), only executables.

I would argue that this is a shortcoming of launch. The command line tool ros2 run as well as launch in ROS 1 are working just fine with scripts. A package could also just provide a ruby / perl (or anything else) script and it needs to work.

(Anyway if we don't know a way to install binaries in two locations it doesn't matter.)

ivanpauno · 2020-07-28T13:37:38Z

Maybe, trying something like this https://stackoverflow.com/questions/54290710/how-to-properly-get-console-scripts-install-scripts-directory

This reverts commit 4139a39.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

dirk-thomas

This should probably target a to-be-created dashing-devel branch.

dirk-thomas · 2020-07-28T19:53:39Z

bin/rqt_graph

+
+from rqt_graph.main import main
+
+sys.exit(main())


Since the file isn't installed to bin it should probably be in differently named directory, e.g. scripts.

Makes sense, see 44266fc

We should consider making a similar change in other rqt packages that use a directory named bin (e.g. rqt_gui).

jacobperron · 2020-07-28T20:38:39Z

This should probably target a to-be-created dashing-devel branch.

To clarify, is the reason because Crystal is EOL, or something else?

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

dirk-thomas · 2020-07-28T21:55:47Z

To clarify, is the reason because Crystal is EOL, or something else?

Yeah, since it is a significant change I would not risk applying it to an EOL distro.

jacobperron · 2020-07-29T18:59:38Z

I've targeted a new dashing-devel branch and ran CI for sanity.

Linux
Linux-aarch64
macOS
Windows

dirk-thomas · 2020-07-30T19:16:07Z

I've targeted a new dashing-devel branch and ran CI for sanity.

@jacobperron Please reference all related PRs / commits here to ensure the branch name was updated in all locations.

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

The latest development branch is `dashing-devel` since ros-visualization/rqt_graph#49. Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron · 2020-07-30T22:19:27Z

Related PRs for ROS 2 Rolling:

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron · 2020-07-30T22:34:00Z

Related PRs for remaining distros:

* Update source branch for rolling The latest development branch is `dashing-devel` since ros-visualization/rqt_graph#49. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update branches for dashing, eloquent, and foxy Signed-off-by: Jacob Perron <jacob@openrobotics.org>

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

Install exectuable rqt_graph

4219ab5

This fixes a regression introduced in #42. Now the application can be started with 'rqt_graph' or with 'ros2 run' Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron mentioned this pull request Jul 28, 2020

Add setup.cfg with script install directories #42

Merged

ivanpauno reviewed Jul 28, 2020

View reviewed changes

jacobperron added 2 commits July 28, 2020 10:50

Revert "Add setup.cfg with script install directories (#42)"

f3d688f

This reverts commit 4139a39.

Install entrypoint to bin/ and executable to lib/rqt_graph/

a6b3654

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

ivanpauno approved these changes Jul 28, 2020

View reviewed changes

dirk-thomas reviewed Jul 28, 2020

View reviewed changes

Move script to 'scripts' directory

44266fc

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

dirk-thomas approved these changes Jul 28, 2020

View reviewed changes

jacobperron changed the base branch from crystal-devel to dashing-devel July 28, 2020 22:38

jacobperron merged commit 9bce79c into dashing-devel Jul 29, 2020

jacobperron deleted the jacob/rqt_graph_bin branch July 29, 2020 19:00

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph

fa83e76

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

This was referenced Jul 30, 2020

Update branch for rqt_graph ros2/ros2#992

Merged

Update rqt_graph development branch for Dashing and later ros/rosdistro#26005

Merged

jacobperron added a commit to ros2-gbp/rqt_graph-release that referenced this pull request Jul 30, 2020

Update source branch for rolling

946e9d0

The latest development branch is `dashing-devel` since ros-visualization/rqt_graph#49. Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron mentioned this pull request Jul 30, 2020

Update source branch for dashing track and later ros2-gbp/rqt_graph-release#1

Merged

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992)

f15da6d

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992)

f180561

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992)

5b1d7ab

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

This was referenced Jul 30, 2020

[foxy] Update branch for rqt_graph (#992) ros2/ros2#993

Merged

[eloquent] Update branch for rqt_graph (#992) ros2/ros2#994

Merged

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992)

4bf090f

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron mentioned this pull request Jul 30, 2020

[dashing] Update branch for rqt_graph (#992) ros2/ros2#995

Merged

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992) (#995)

70d151b

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992) (#994)

33ef1bb

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

jacobperron added a commit to ros2/ros2 that referenced this pull request Jul 30, 2020

Update branch for rqt_graph (#992) (#993)

9a834af

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

eholum pushed a commit to eholum/space-ros that referenced this pull request Jun 26, 2024

Update branch for rqt_graph (space-ros/docker#992)

75ab8f5

The dashing-devel branch was created since ros-visualization/rqt_graph#49 Signed-off-by: Jacob Perron <jacob@openrobotics.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install executable rqt_graph #49

Install executable rqt_graph #49

jacobperron commented Jul 28, 2020

ivanpauno Jul 28, 2020 •

edited

Loading

dirk-thomas Jul 28, 2020

jacobperron Jul 28, 2020

ivanpauno Jul 28, 2020

dirk-thomas Jul 28, 2020

ivanpauno Jul 28, 2020

dirk-thomas Jul 28, 2020 •

edited

Loading

ivanpauno commented Jul 28, 2020

dirk-thomas left a comment

dirk-thomas Jul 28, 2020

jacobperron Jul 28, 2020

jacobperron commented Jul 28, 2020

dirk-thomas commented Jul 28, 2020

jacobperron commented Jul 29, 2020 •

edited

Loading

dirk-thomas commented Jul 30, 2020 •

edited

Loading

jacobperron commented Jul 30, 2020

jacobperron commented Jul 30, 2020

Install executable rqt_graph #49

Install executable rqt_graph #49

Conversation

jacobperron commented Jul 28, 2020

ivanpauno Jul 28, 2020 • edited Loading

Choose a reason for hiding this comment

dirk-thomas Jul 28, 2020

Choose a reason for hiding this comment

jacobperron Jul 28, 2020

Choose a reason for hiding this comment

ivanpauno Jul 28, 2020

Choose a reason for hiding this comment

dirk-thomas Jul 28, 2020

Choose a reason for hiding this comment

ivanpauno Jul 28, 2020

Choose a reason for hiding this comment

dirk-thomas Jul 28, 2020 • edited Loading

Choose a reason for hiding this comment

ivanpauno commented Jul 28, 2020

dirk-thomas left a comment

Choose a reason for hiding this comment

dirk-thomas Jul 28, 2020

Choose a reason for hiding this comment

jacobperron Jul 28, 2020

Choose a reason for hiding this comment

jacobperron commented Jul 28, 2020

dirk-thomas commented Jul 28, 2020

jacobperron commented Jul 29, 2020 • edited Loading

dirk-thomas commented Jul 30, 2020 • edited Loading

jacobperron commented Jul 30, 2020

jacobperron commented Jul 30, 2020

ivanpauno Jul 28, 2020 •

edited

Loading

dirk-thomas Jul 28, 2020 •

edited

Loading

jacobperron commented Jul 29, 2020 •

edited

Loading

dirk-thomas commented Jul 30, 2020 •

edited

Loading