Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better nosetest build folder naming #381

Closed
wants to merge 1 commit into from

Conversation

stonier
Copy link
Contributor

@stonier stonier commented Mar 12, 2013

Windows failing to build genmsg which uses

catkin_add_nosetests(${PROJECT_SOURCE_DIR})

and it falls all over the C:\ prefix to the path. This led to finding this bit of code:

  • Was it actually intending to strip the source directory and not the binary directory? I can't see the reason you'd want to strip the binary directory and stripping the source directory makes it more convenient for introspection.
  • This regex replace code is quite a bit simpler for removing prefixes
  • Provides a name when ends up with the empty string (could maybe choose a better name?)
  • Also replaces colons with dots to avoid problem windows path characters.

@dirk-thomas
Copy link
Member

Can you please test the branch cleaner_nosetest_target_names, verify that it does what you wanted to achieve and report back?

@stonier
Copy link
Contributor Author

stonier commented Mar 12, 2013

👍 - branch changes work fine.

@dirk-thomas
Copy link
Member

New pull request pending: #382

dirk-thomas added a commit that referenced this pull request Mar 13, 2013
modified nosetest target name suffixes (#381)
cwecht pushed a commit to cwecht/catkin that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants