Remove some hackish workarounds for windows #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add_library macro for windows was using some hackish assumptions to ensure that libraries get installed properly. This doesn't always work as it makes the assumption that the user actually wanted to install the target. Better to remove this and do it properly (e.g. see ros/roscpp_core#10)
This was referenced Mar 15, 2013
dirk-thomas
added a commit
that referenced
this pull request
Mar 20, 2013
Remove some hackish workarounds for windows
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_library macro for windows was using some hackish assumptions
to ensure that libraries get installed properly.
This doesn't always work as it makes the assumption that the user actually
wanted to install the target.
Better to remove this and do it properly (e.g. see ros/roscpp_core#10)
This also fixes #389.