Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning #151

Merged
merged 1 commit into from May 6, 2020
Merged

Fixed warning #151

merged 1 commit into from May 6, 2020

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented May 5, 2020

Fixed warning introduced by this PR #141 (comment)

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this May 5, 2020
@ahcorde
Copy link
Author

ahcorde commented May 5, 2020

CI run up-to class_loader, because the PR includes only new tests

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request May 5, 2020
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

When you're posting CI, please include in the comment what CI settings you used and why too. That way people can audit it without clicking through and trying to figure out why you limited it to one thing or the other.

@ahcorde ahcorde merged commit 1e9b4eb into ros2 May 6, 2020
@clalancette clalancette deleted the ahcorde/fix/warning branch November 30, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants