Skip to content

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 7, 2020

Precisely what the title says, for ros1 support.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@nuclearsandwich
Copy link
Member

nuclearsandwich commented Oct 7, 2020

There is a noetic-devel branch as well but it isn't the default and it has not been used for a release to the best of my memory.

Edit: actually it has https://github.com/ros/class_loader/tree/noetic-devel, 0.5.0

@hidmic hidmic changed the base branch from melodic-devel to noetic-devel October 8, 2020 19:21
@hidmic
Copy link
Contributor Author

hidmic commented Oct 8, 2020

@nuclearsandwich just re-targeted this PR against noetic-devel. Should we make it the default? WDYT @mjcarroll ?

@nuclearsandwich
Copy link
Member

Should we make it the default?

Probably. It was only time and attention deficit after an oversight that kept me from doing so.

@mjcarroll
Copy link
Member

Should we make it the default? WDYT @mjcarroll ?

Agree, we should make it default.

@mjcarroll mjcarroll merged commit 4a9ed1a into noetic-devel Oct 9, 2020
@mjcarroll mjcarroll deleted the hidmic/update-ros1-maintainers branch October 9, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants