Fix pkg-config file to respect ${prefix} variable for libs and headers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plead guilty on this one. However the solution proposed here would be better be replaced by |
Suggested by Thomas Moulard
|
hehe, I knew that was a good option to CC you on this one. I've updated the pull request with your recommendation. Thanks. BTW, I will add the patch to debian-science until we have a new release of console-bridge with this fix. |
isucan
added a commit
that referenced
this pull request
Feb 16, 2014
Fix pkg-config file to respect ${prefix} variable for libs and headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current pkg-config file does not include the ${prefix} pkg-config variable so the final result is not an absolute path but a relative one ('lib/').
Error was detected while testing sdformat using urdfdom pkg-config file, which will use console_bridge and end up showing errors like this. Fixing the console bridge pkg-config manually, with this pull request changes, fix the issue for me.
I believe that was @thomas-moulard who introduced the changes to the pkg config file.