Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC disable -Wno-deprecated-declarations #36

Merged
merged 2 commits into from
Feb 2, 2016

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Feb 1, 2016

Fixes the Windows build.
Closes #34.

Waiting to make sure that appveyor is enabled.

@tfoote tfoote closed this Feb 1, 2016
@tfoote tfoote reopened this Feb 1, 2016
@scpeters
Copy link
Contributor Author

scpeters commented Feb 1, 2016

Ok, it looks like appveyor is set up (thanks @tfoote ). @traversaro do you know why this proposed fix isn't working?

@scpeters
Copy link
Contributor Author

scpeters commented Feb 1, 2016

I've fixed linking, but the tests don't like to run on windows because console_bridge.dll isn't in the same folder as the test executable.

@scpeters scpeters changed the title MSCV disable -Wno-deprecated-declarations MSVC disable -Wno-deprecated-declarations Feb 1, 2016
@scpeters scpeters force-pushed the appveyor_github_test branch 2 times, most recently from 64eb601 to 0d83ff0 Compare February 2, 2016 00:46
Also fix gtest linking.
Fixes the Windows build.
Closes ros#34.
@scpeters
Copy link
Contributor Author

scpeters commented Feb 2, 2016

This fixes the windows build. The tests are still broken, so I've disabled them for now.

scpeters added a commit that referenced this pull request Feb 2, 2016
MSVC disable -Wno-deprecated-declarations
@scpeters scpeters merged commit ed29e63 into ros:master Feb 2, 2016
@scpeters scpeters deleted the appveyor_github_test branch February 2, 2016 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants