Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide PROJECT_SOURCE_DIR to cpplint #97

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Provide PROJECT_SOURCE_DIR to cpplint #97

merged 1 commit into from
Apr 25, 2023

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jun 10, 2022

to fix eg:

3/3 Test #3: console_bridge_cpplint3/3 Test #3: console_bridge_cpplint............***Failed    0.15 sec
…/src/console_bridge-1.0.2/include/console_bridge/console.h:37:  #ifndef header guard has wrong style, please use: SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_  [build/header_guard] [5]
…/src/console_bridge-1.0.2/include/console_bridge/console.h:192:  #endif line should be "#endif  // SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_"  [build/header_guard] [5]

@nim65s
Provide PROJECT_SOURCE_DIR to cpplint
e6ace20 
to fix eg:

3/3 Test ros#3: console_bridge_cpplint3/3 Test ros#3: console_bridge_cpplint............***Failed    0.15 sec
…/src/console_bridge-1.0.2/include/console_bridge/console.h:37:  #ifndef header guard has wrong style, please use: SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_  [build/header_guard] [5]
…/src/console_bridge-1.0.2/include/console_bridge/console.h:192:  #endif line should be "#endif  // SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_"  [build/header_guard] [5]

Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
@nim65s
Copy link
Contributor Author

nim65s commented Apr 19, 2023

Hi,

This is a gentle ping. Is there anything missing here ?

@traversaro
Copy link
Contributor

fyi @scpeters per #96 (comment)

@nim65s
Copy link
Contributor Author

nim65s commented Apr 20, 2023

Oh, I see. Thanks @traversaro !

scpeters
scpeters approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the test failure anymore on master but this change seems right. Sorry for the delayed review and thanks for your contribution!

@scpeters scpeters merged commit 7048ab4 into ros:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nim65s @traversaro @scpeters