Adding date-time to frame output files #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
requested changes
May 14, 2021
There was a problem hiding this comment.
This is a notable behavior change to be able to release it into active distros it would have to be opt in. I'd recommend targeting this as the new version in ros2/geometry2 https://github.com/ros2/geometry2/blob/ros2/tf2_tools/tf2_tools/view_frames.py where we can land this behavior for future rosdistros.
ooeygui
pushed a commit
to ms-iot/geometry2
that referenced
this pull request
Oct 12, 2022
* Disable mem-access warnings on aarch64. There is currently a bug in Eigen in Ubuntu 22.04 meaning that it throws a mem-access warning every time Eigen/PacketMath.h is used. There is an upstream fix for it, and we are trying to get that into Ubuntu 22.04, but that is not guaranteed. For now, disable the warning only if we are on GCC. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyed by making multiple frames, when making minute changes, only to find that I have overwritten a frame.
This PR just adds date-time tag to the output file, creating
frames_YYYY-MM-DD_HH.MM.SS.gvandframes_YYYY-MM-DD_HH.MM.SS.pdffiles.